Reflect legacy payload type handling implementation in BOLT #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Nov 22, 2019
There was a problem hiding this comment.
I think this is already covered in the "Packet Structure" section:
The length field determines both the length and the format of the hop_payload field; the following formats are defined:
Legacy hop_data format, identified by a single 0x00 byte for length. In this case the hop_payload_length is defined to be 32 bytes.
Although it may be the case that we need to make this more explicit.
niftynei
added
the
clarification
|
@arik-so do you think this clarification is still needed? If so can you rebase your PR and we'll include it? |
In sphinx.go, legacy payloads are not given a length prefix byte.
|
We got rid of the legacy format in #962 so we don't need this PR anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sphinx.go, legacy payloads are not given a length prefix byte.