Use onion amount in MPP set calculation #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sender chooses the amounts that are set in the onion payload (`amt_to_forward`) but cannot predict what amounts will be set in the HTLCs (`amount_msat`) since intermediate nodes are allowed to overpay.
28 tasks
joostjager
reviewed
Nov 18, 2022
These requirements were missed when integrating lightning#1032
|
ACK |
TheBlueMatt
approved these changes
Nov 21, 2022
carlaKC
approved these changes
Nov 21, 2022
halseth
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
As mentioned during the call, this was discussed earlier: #1032 (comment). The conclusion then was that the change was not strictly needed (sender should always be able to handle a premature preimage release).
But I'm for it, this makes it simpler to reason about, and gives routing nodes less room to play around with the settlement.
ACK
|
Right, thanks for the link! I only focused on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sender chooses the amounts that are set in the onion payload (
amt_to_forward) but cannot predict what amounts will be set in the HTLCs (amount_msat) since intermediate nodes are allowed to overpay.This was pointed out by @joostjager here.