Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump versions of Scala, sbt, plugins, ScalaTest #203

Merged
merged 3 commits into from
Feb 27, 2018
Merged

bump versions of Scala, sbt, plugins, ScalaTest #203

merged 3 commits into from
Feb 27, 2018

Conversation

SethTisue
Copy link
Collaborator

No description provided.

@SethTisue SethTisue requested a review from 2m February 16, 2018 21:37
sbtVersion in Global := "0.13.13", // Should be ThisBuild, but ^^ uses Global (incorrectly)
crossSbtVersions := List("0.13.13", "1.0.0-RC3"), // Should be ThisBuild, but Defaults defines it at project level..
sbtVersion in Global := "0.13.17", // Should be ThisBuild, but ^^ uses Global (incorrectly)
crossSbtVersions := List("0.13.17", "1.1.1"), // Should be ThisBuild, but Defaults defines it at project level..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As sbt plugins API is not forwards-compatible, I think we should use the latest version of the 1.0.x series here. So we make sure that we do not use features from 1.1.x and break the plugin for 1.0.x users.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because no version of sbt (including 1.0.x releases) is forwards-compatible I suggest we use 0.13.13 and 1.0.0.

@SethTisue SethTisue changed the title bump versions of Scala, sbt, plugins bump versions of Scala, sbt, plugins, ScalaTest Feb 22, 2018
@SethTisue
Copy link
Collaborator Author

revised based on feedback from Martynas and Dale. @dwijnand okay but should .travis.yml have 1.1.1 or 1.0.0?

@dwijnand
Copy link
Collaborator

I'm thinking 1.0.0 (and 0.13.13)..

  1. if we test in CI with 1.0.0 we know it works with 1.0.0 and don't know if it works with 1.1.1
  2. if we test in CI with 1.1.1 we know it works with 1.1.1 and don't know if it works with 1.0.0

but I think (1) is the safer bet: assume that it will also work with 1.1.1. wdyt?

@SethTisue
Copy link
Collaborator Author

My thinking was that we care most whether it works on the latest, actually, since the latest is what we hope people use. I suppose we could test both oldest and latest?

@dwijnand
Copy link
Collaborator

if the matrix doesn't explode, then sgtm

@SethTisue SethTisue merged commit 6f2f44b into lightbend-labs:master Feb 27, 2018
@SethTisue SethTisue deleted the version-bumps branch February 27, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants