-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump versions of Scala, sbt, plugins, ScalaTest #203
Conversation
project/Build.scala
Outdated
sbtVersion in Global := "0.13.13", // Should be ThisBuild, but ^^ uses Global (incorrectly) | ||
crossSbtVersions := List("0.13.13", "1.0.0-RC3"), // Should be ThisBuild, but Defaults defines it at project level.. | ||
sbtVersion in Global := "0.13.17", // Should be ThisBuild, but ^^ uses Global (incorrectly) | ||
crossSbtVersions := List("0.13.17", "1.1.1"), // Should be ThisBuild, but Defaults defines it at project level.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As sbt plugins API is not forwards-compatible, I think we should use the latest version of the 1.0.x series here. So we make sure that we do not use features from 1.1.x and break the plugin for 1.0.x users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because no version of sbt (including 1.0.x releases) is forwards-compatible I suggest we use 0.13.13 and 1.0.0.
revised based on feedback from Martynas and Dale. @dwijnand okay but should |
I'm thinking 1.0.0 (and 0.13.13)..
but I think (1) is the safer bet: assume that it will also work with 1.1.1. wdyt? |
My thinking was that we care most whether it works on the latest, actually, since the latest is what we hope people use. I suppose we could test both oldest and latest? |
if the matrix doesn't explode, then sgtm |
No description provided.