Get new instance of mutable mima instance #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks right :) i guess you tested it locally? |
|
Yes. And on the Scala build. That is how I found this bug.
…On Thu, Jun 8, 2017, 10:34 Lukas Rytz ***@***.***> wrote:
looks right :) i guess you tested it locally?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZwxiU-yeQCnviyhCNPjYn1UqXgmWrzks5sB6QZgaJpZM4NwAvl>
.
|
lrytz
approved these changes
Jun 8, 2017
dwijnand
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiMaLib accumulates problems in a mutable list buffer. Therefore we need to create a new MiMaLib instance between checking for backward and forward BC problems.
This change is required to be able to check for BC probems in
bothdirections (like in Scala).