#170 Add filter file support #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2017
|
Created two PRs in akka and akka-http that use this functionality to validate the approach. :) |
2m
force-pushed
the
wip-filters-from-file-2m
branch
from
6da0afc to
4f69c75
Compare
|
I have tried this PR with akka, akka-http and scala projects with successful results. Can someone give a LGTM so we can merge this? Do not be discouraged by the large amount of changed files. Most of them are new scripted tests. |
dwijnand
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter file is a different format from the one that is supported by the CLI. A different format was chosen partly because it is less verbose and partly because such format is already used in akka-http.
Fixes #170