regression: command line MiMa performs no checks unless --direction ... is provided #137
Milestone
Comments
retronym
added a commit
to retronym/migration-manager
that referenced
this issue
Nov 16, 2016
Since 2844ffa, running MiMa from the CLI has been a no-op unless the new option `--direction backwards` was provided. Only the SBT plugin correctly used the default value. Noticed in the SBT build of Scala on the 2.12.x branch, where we use MiMa be calling `Main.main` from our build for some reason, rather than using the SBT plugin directly. This commit restores the old behaviour when that parameter is missing, as manually tested with: ``` % sbt reporter/runMain com.typesafe.tools.mima.cli.Main --prev /Users/jz/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.0-RC1.jar --curr /Users/jz/code/scala/build/pack/lib/scala-library.jar [info] Compiling 1 Scala source to /Users/jz/code/migration-manager/reporter/target/scala-2.10/classes... [info] Running com.typesafe.tools.mima.cli.Main --prev /Users/jz/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.0-RC1.jar --curr /Users/jz/code/scala/build/pack/lib/scala-library.jar Found 13 binary incompatibilities ================================= * method TRAIT_SETTER_SEPARATOR_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method NAME_JOIN_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method SETTER_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method LAZY_LOCAL_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method LOCAL_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method MODULE_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method MODULE_INSTANCE_NAME()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method loadFactorDenum()Int in object scala.collection.mutable.HashTable does not have a correspondent in current version * method printSizeMap()Unit in interface scala.collection.mutable.HashTable does not have a correspondent in current version * method findEntry0(java.lang.Object,Int)scala.collection.mutable.HashEntry in interface scala.collection.mutable.HashTable is present only in current version * method addEntry0(scala.collection.mutable.HashEntry,Int)Unit in interface scala.collection.mutable.HashTable is present only in current version * method foo()Int in interface scala.collection.mutable.HashTable is present only in current version * method isJavaAtLeast(Int)Boolean in interface scala.util.PropertiesTrait is present only in current version Exception: sbt.TrapExitSecurityException thrown from the UncaughtExceptionHandler in thread "run-main-6" java.lang.RuntimeException: Nonzero exit code: 13 at scala.sys.package$.error(package.scala:27) [trace] Stack trace suppressed: run last reporter/compile:runMain for the full output. [error] (reporter/compile:runMain) Nonzero exit code: 13 [error] Total time: 2 s, completed 16/11/2016 3:36:25 PM ``` Fixes lightbend-labs#137
|
great catch. one hopes pretty much everybody (but us) has been using the sbt plugin :-\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Regressed in 2844ffa#diff-3383cbf2c9d69641a9962eba1953e3a0R118 (both forwards and backwards checks use
direction.getOrElse(Nil)(that's odd in itself, whyNilrather than""?)Currently, the SBT build for Scala calls
Maindirectly rather than using the SBT plugin. As such, we've been flying blind (and been blind to our blindness).The text was updated successfully, but these errors were encountered: