fix: make route scope relevant for IPv4 only #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you create some e2e tests for this? Ideally with the fix you did before. The e2e tests are better to catch regressions in the future. |
VladoLavor
changed the title
VladoLavor
force-pushed
the
master
branch
3 times, most recently
from
024ddca to
fd956d0
Compare
* added E2E tests Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
ondrej-fabry
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 route scope is resolved by the OS and cannot be changed or read by Netlink
Signed-off-by: Vladimir Lavor vlavor@cisco.com