feat: Support for cache DNS server in VPP + e2e test refactoring #1779
Conversation
refactor: deduplicated common container related code and commands run in container Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
refactor: big refactoring making test topology components (agent, ms, etcd, dns server) decoupled from underlaying docker runtime (some test specific help methods need to be yet change) Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…ainer as DNS server Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…r struct where it logically belongs + added some todos to do the same for other test components Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
… execCmd configuration with vpp-agent configuration Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
fgschwan
changed the title
|
Unit test + integration tests (vpp 20.01,20.05,20.09) + e2e tests (vpp 20.01,20.05,20.09) were successful. |
| // EquivalentDNSServers determines whether 2 DNS servers are logically equal. This comparison takes | ||
| // into consideration also semantics that couldn't be modeled into proto models (i.e. upstream servers are | ||
| // IP addresses and not only strings) | ||
| func (d *DNSServerDescriptor) EquivalentDNSServers(key string, oldDNSServer, newDNSServer *dns.DNSServer) bool { |
There was a problem hiding this comment.
EquivalentDNSServers could compare UpstreamDnsServers as sets, i.e. different order of the same set of values could be considered equivalent. Otherwise it behaves just like proto.Equal and so it is not neccessarry.
There was a problem hiding this comment.
Upstream DNS server is a list and not a set. Removing EquivalentDNSServers. Fixed in ac77bf2
| return nil, nil | ||
| } | ||
|
|
||
| func (d *DNSServerDescriptor) updateUpstreamDNSServerList(oldServers, newServers []string) error { |
There was a problem hiding this comment.
Could be more efficient - delete only the obsolete entries and add only the truly new ones. Otherwise it is essentially re-create and so the Update method could be omitted.
There was a problem hiding this comment.
Initially i wanted to do it efficiently until i realized that it is not possible. VPP doesn't allow me to insert new upstream DNS server into proper place in the list, but just append at the end of list. Hence the recreate. However i forgot to reevaluate the usefulness of the Update function implementation.
Fixed in ac77bf2.
proto/ligato/vpp/dns/models.go
Outdated
| // DNSServer is registered NB model of DNSServer | ||
| ModelDNSServer = models.Register(&DNSServer{}, models.Spec{ | ||
| Module: ModuleName, | ||
| Type: "dnsserver", |
There was a problem hiding this comment.
I would maybe go with type "dnscache" (likewise for proto message name), just to make it clear that this is not actually a proper DNS server.
Version can be "v1" since this is the first version of the model.
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
I will add only the simple functionality (turn it on and configure the upstream DNS server that will VPP consult for unknown domain names).
However, this PR will contain also e2e test and related e2e changes. These related changes touched some basic things that lead to some heavy e2e refactoring (docker contrainer code deduplication, decupling of basic test topology components (agent,etcd,microservices,...) with underlaying runtime (docker containers)).