Permit agent to run even when VPP stats are unavailable #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
- Coverage 57.93% 57.93% -0.01%
==========================================
Files 370 370
Lines 30147 30148 +1
==========================================
Hits 17467 17467
- Misses 11234 11235 +1
Partials 1446 1446
Flags with carried forward coverage won't be shown. Click here to find out more. |
rastislavs
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes situations where agent cannot connect to stats or when there is with compatibility, e.g. when stats segment version changes. This fixes VPP 20.09 support until GoVPP is compatible with version 2 of stat segment (already in progress by @VladoLavor)