-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Switch to new proto v2 #1691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewenset
reviewed
Jul 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
=======================================
Coverage 58.00% 58.00%
=======================================
Files 370 370
Lines 30095 30093 -2
=======================================
Hits 17456 17456
+ Misses 11197 11193 -4
- Partials 1442 1444 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com> # Conflicts: # proto/ligato/vpp/ipsec/ipsec.pb.go # proto/ligato/vpp/vpp.pb.go
ondrej-fabry
force-pushed
the
new-protobuf2
branch
from
August 14, 2020 08:24
d51461d
to
26289a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Protobuf-Go to v2
Protobuf-Go
github.com/golang/protobuf
togoogle.golang.org/protobuf
(now uses vanity import path and the actual repo is at: https://github.com/protocolbuffers/protobuf-go)
v2
is actually>=v1.20.0
The project authors decided to not increase major number, because of the import path changing completely
(which is actually the important part for Go modules when doing breaking changes to an API)
proto.Message
has just a single method that returns the message reflectXXX_*
)v1
is actually<=v1.4.0
The module
github.com/golang/protobuf
has switched its implementation inv1.4.0
to use the new v2 API under the hood while still providing the legacy v1 API and the v2 API allows backwards compatibility by providing conversions from v1github.com/golang/protobuf v1.4.0
go.mod
depends on the newgoogle.golang.org/protobuf v1.21.0
google.golang.org/protobuf v1.20.0
go.mod
depends on the oldgithub.com/golang/protobuf v1.4.0-rc.2
gRPC
protoc-gen-go
and has been moved togrpc-go
repo and now it is a separate generatorprotoc-gen-go-grpc
(executed from theprotoc
)*_grpc.pb.go
Unimplemented*
(this is most likely to avoid panics on when embedding nil interface)
Links for more info