Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpp/ifplugin): Recognize interface name prefix "tun" as TAP #1674

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

ondrej-fabry
Copy link
Member

This PR should fix resync issue for VPP TAPs with tunnel mode.

It will work correctly when this VPP change gets merged: https://gerrit.fd.io/r/c/vpp/+/27769

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
67.3% 67.3% Duplication

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #1674 into master will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   58.35%   58.07%   -0.28%     
==========================================
  Files         597      366     -231     
  Lines       48260    30045   -18215     
==========================================
- Hits        28164    17450   -10714     
+ Misses      17197    11155    -6042     
+ Partials     2899     1440    -1459     
Flag Coverage Δ
#e2e ?
#unittests 58.07% <100.00%> (ø)

@ondrej-fabry ondrej-fabry merged commit e9aa355 into ligato:master Jul 3, 2020
@ondrej-fabry ondrej-fabry deleted the fix-tap-tunnel branch July 3, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants