Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if HostIfName contains non-printable characters #1662

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

ondrej-fabry
Copy link
Member

Signed-off-by: Ondrej Fabry ofabry@cisco.com

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry added the 🚧 WIP do not merge! work in progress! label Jun 2, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
71.2% 71.2% Duplication

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1662 into master will increase coverage by 1.04%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
+ Coverage   57.19%   58.23%   +1.04%     
==========================================
  Files         594      365     -229     
  Lines       47846    29882   -17964     
==========================================
- Hits        27367    17403    -9964     
+ Misses      17660    11047    -6613     
+ Partials     2819     1432    -1387     
Flag Coverage Δ
#e2e ?
#unittests 58.23% <55.55%> (-0.01%) ⬇️

@ondrej-fabry ondrej-fabry merged commit 218575e into ligato:master Jun 5, 2020
@ondrej-fabry ondrej-fabry deleted the hostifname branch June 5, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP do not merge! work in progress!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant