Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes and improvements for agentctl and models #1643

Merged
merged 13 commits into from
Mar 18, 2020
Merged

Conversation

ondrej-fabry
Copy link
Member

No description provided.

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry requested a review from rastislavs March 18, 2020 13:49
@ondrej-fabry ondrej-fabry self-assigned this Mar 18, 2020
@ondrej-fabry ondrej-fabry marked this pull request as ready for review March 18, 2020 13:49
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #1643 into master will decrease coverage by 0.02%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
- Coverage   58.13%   58.11%   -0.03%     
==========================================
  Files         293      293              
  Lines       23836    23848      +12     
==========================================
+ Hits        13858    13859       +1     
- Misses       8847     8858      +11     
  Partials     1131     1131              
Flag Coverage Δ
#unittests 58.11% <13.33%> (-0.03%) ⬇️

rastislavs
rastislavs previously approved these changes Mar 18, 2020
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry merged commit 615f9fd into master Mar 18, 2020
@ondrej-fabry ondrej-fabry deleted the improve branch March 18, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants