feat: Allow AF-PACKET to reference target Linux interface via logical name #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
+ Coverage 49.69% 51.96% +2.27%
==========================================
Files 600 304 -296
Lines 63595 26372 -37223
==========================================
- Hits 31604 13705 -17899
+ Misses 29562 11574 -17988
+ Partials 2429 1093 -1336
|
ondrej-fabry
previously approved these changes
Feb 6, 2020
|
LGTM. Just rebase on master, since vpp2001_324 has been removed. |
golangcibot
reviewed
Feb 7, 2020
… name Added <linux_interface> field to AF-PACKET link definition, which allows to reference the target Linux interface via logical name as opposed to its host name. Previously the physical reference was chosen over the logical because it was not possible to reference Linux interfaces not managed by the same vpp-agent, but with the introduction of the EXISTING Linux interface type this is no longer the case. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
ondrej-fabry
approved these changes
Feb 7, 2020
rastislavs
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added <linux_interface> field to AF-PACKET link definition, which
allows to reference the target Linux interface via logical name
as opposed to its host name. Previously the physical reference
was chosen over the logical because it was not possible to reference
Linux interfaces not managed by the same vpp-agent, but with the
introduction of the EXISTING Linux interface type this is no longer
the case.
Signed-off-by: Milan Lenco milan.lenco@pantheon.tech