Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAssayfor() Optional Column possible correction #31

Closed
SurajViitk opened this issue Jun 7, 2020 · 2 comments
Closed

getAssayfor() Optional Column possible correction #31

SurajViitk opened this issue Jun 7, 2020 · 2 comments

Comments

@SurajViitk
Copy link
Contributor

I think m.matches() here should be replaced with m.find() because a possible value for identifier is assay[1]_peak_mz or as given in this example, it could be assay[1]_my_value for which m.matches() will give false
@SurajViitk SurajViitk mentioned this issue Jun 7, 2020
Merged
nilshoffmann pushed a commit that referenced this issue Jun 8, 2020
Fixes #31, added Test.
a55c97e
@nilshoffmann
Copy link
Member

@SurajViitk Snapshot build has been deployed. Please test!

@SurajViitk
Copy link
Contributor Author

test done, working fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nilshoffmann @SurajViitk