Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malfunctioning test_tree_visualiser.lua #6

Closed
mathemage opened this issue Dec 26, 2017 · 4 comments
Closed

Malfunctioning test_tree_visualiser.lua #6

mathemage opened this issue Dec 26, 2017 · 4 comments

Comments

@mathemage
Copy link

Hi @lifrordi !

When my settings Settings/arguments.lua is:

--- list of pot-scaled bet sizes to use in tree
-- @field params.bet_sizing
params.bet_sizing = {1}

and visualizing by running command:

$ th Tree/Tests/test_tree_visualiser.lua

I get the following visualization:
simple_tree_1bet

However, when I modify Settings/arguments.lua as follows:

params.bet_sizing = {1, 2}

and when I run the very same command, I get this visualization:
simple_tree_12bet
This is obviously incorrect, since we should have more bet actions, namely "2-pot bet". Am I missing something, or are the two visualizations supposed to be identical?

Thanks for clarification!

@mathemage
Copy link
Author

But when I run test_tree_values.lua, it seems to makes difference!

For 1-pot bets:

$ th Tree/Tests/test_tree_values.lua 
Exploitability: 175.52084350586[chips]  

For 1- and 2-pot bets:

$ th Tree/Tests/test_tree_values.lua 
Exploitability: 197.78327178955[chips]  

@snarb
Copy link

snarb commented Dec 26, 2017

You can't get 2x in that situation. Stack size is 300 + 300 = 600. 1x bet is +600. That is ok. But 2x bet will be +1200, totally 600 + 1200 = 1800 that is impossible with stack size 1200.

mathemage added a commit to mathemage/DeepStack-Leduc that referenced this issue Dec 26, 2017
@mathemage
Copy link
Author

@snarb Oh I see, the stack sizes are set to 1200. I haven't noticed that... I was simply following the tutorial, where it is not mentioned.

@lifrordi I suggest mentioning it there.

@mathemage
Copy link
Author

Increasing stack sizes to 12000 works:
simple_tree_12bet_stack12000

Thanks a lot, @snarb & @lifrordi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants