Deploy all contracts to ink #1016
Conversation
|
Warning Rate limit exceeded@0xDEnYO has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis pull request integrates support for the new INK network. It adds a new Ethereum node URI variable ( Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/gaszip.json (1)
16-16: New INK Router Entry AddedThe addition of the
"ink"entry with the address"0x2a37D63EAdFe4b4682a3c28C1c2cD4F109Cc2762"is consistent with other network entries. Please verify that using the same router address as the"mainnet"entry is intentional for the ink network.deployments/ink.diamond.json (1)
69-83: Periphery Configuration – Review Empty EntriesIn the
"Periphery"section, several components like"LiFuelFeeCollector","Permit2Proxy","Receiver", and"RelayerCelerIM"have empty string values. If these are intentionally left unassigned for future deployment or configuration, it might help to add a comment or a TODO note to clarify the intent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (18)
.env.example(1 hunks).github/workflows/diamondEmergencyPause.yml(1 hunks)config/across.json(1 hunks)config/dexs.json(2 hunks)config/gaszip.json(1 hunks)config/global.json(1 hunks)config/networks.json(1 hunks)config/relay.json(2 hunks)config/stargate.json(4 hunks)config/tokenwrapper.json(1 hunks)deployments/_deployments_log_file.json(25 hunks)deployments/ink.diamond.json(1 hunks)deployments/ink.json(1 hunks)foundry.toml(3 hunks)networks(1 hunks)script/deploy/_targetState.json(2 hunks)script/deploy/healthCheck.ts(0 hunks)script/tasks/diamondUpdateFacet.sh(1 hunks)
💤 Files with no reviewable changes (1)
- script/deploy/healthCheck.ts
✅ Files skipped from review due to trivial changes (1)
- networks
🧰 Additional context used
🧠 Learnings (2)
.github/workflows/diamondEmergencyPause.yml (1)
Learnt from: 0xDEnYO
PR: lifinance/contracts#894
File: .github/workflows/diamondEmergencyPause.yml:82-82
Timestamp: 2024-12-05T03:42:41.402Z
Learning: The `ETH_NODE_URI_WORLDCHAIN` secret is correctly configured in the GitHub repository.
script/deploy/_targetState.json (1)
Learnt from: ezynda3
PR: lifinance/contracts#861
File: script/deploy/_targetState.json:1453-1483
Timestamp: 2024-11-21T08:24:53.059Z
Learning: In `script/deploy/_targetState.json`, for the `abstract` network configuration, `ReceiverStargateV2` is correctly set to version `1.0.1`.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: run-unit-tests
- GitHub Check: run-unit-tests
🔇 Additional comments (45)
deployments/ink.json (1)
1-27: New INK Facets Configuration File Looks CorrectThis new JSON file correctly lists all the facet names mapped to their corresponding Ethereum addresses for the ink network deployment. The structure is valid and consistent with the diamond architecture pattern requirements.
config/global.json (1)
5-5: INK Factory Address IntegrationThe new key
"ink": "0xeBbbaC35500713C4AD49929e1bE4225c7efF6510"is integrated properly into thecreate3Factoryobject. Ensure that this address has been audited and is correctly associated with the ink network deployment requirements.config/tokenwrapper.json (1)
30-30: TokenWrapper Configuration for INK NetworkThe new entry for
"ink": "0x4200000000000000000000000000000000000006"has been added correctly. Please confirm that this address matches the deployed token wrapper on the ink network and is consistent with other network configurations in the project.deployments/ink.diamond.json (1)
3-68: Facet Configuration for Diamond DeploymentThe
"Facets"section correctly maps facet contract addresses to their names and version numbers. The addresses here match those provided in the other ink-related deployment files. Ensure that the version numbers align with the deployed contract implementations and that they have been verified through prior audits..env.example (1)
21-21: New INK network variable added.
The addition ofETH_NODE_URI_INK=https://rpc-gel.inkonchain.com #[pre-commit-checker: not a secret]is consistent with the existing RPC variable format. Please verify that the provided URI is correct and accessible in the deployment environments..github/workflows/diamondEmergencyPause.yml (1)
69-69: Integration of INK network in workflow.
The new environment variableETH_NODE_URI_INK: ${{ secrets.ETH_NODE_URI_INK }}is added to thePause Diamondjob configuration. Ensure that the corresponding secret is properly configured in the GitHub repository.config/relay.json (1)
66-70: New INK network configuration in relay.json.
The"ink"entry is introduced withchainId: 13371, along with the specifiedrelayReceiverandrelaySolveraddresses. Please verify that these addresses and the chain ID accurately reflect the intended parameters for the INK network.config/across.json (1)
104-109: New INK network entry added.
The configuration for the"ink"network (withchainId: 13371,acrossSpokePool,weth, and an emptytokensToApprovearray) is correctly added. Please confirm that these parameters match the deployment requirements for the INK network.foundry.toml (3)
1-4: Updated Solidity compiler and EVM version.
The update tosolc_version = '0.8.28'andevm_version = 'cancun'in the[profile.default]section is noted. Ensure that these versions are compatible with the current contracts and tooling.
46-48: New RPC endpoint for INK network.
Addingink = "${ETH_NODE_URI_INK}"under[rpc_endpoints]is correctly implemented. Please verify that the environment variable is populated and that the endpoint is accessible in all relevant environments.
97-97: Etherscan integration for INK network.
The etherscan entry forinkhas been added:ink = { key = "${INK_ETHERSCAN_API_KEY}", url = "https://explorer.inkonchain.com/api/", verifier = "blockscout", chain = "57073"}Please confirm that the chain ID
57073and the API endpoint match the INK network’s specifications.script/tasks/diamondUpdateFacet.sh (1)
121-125: Enhanced JSON Log Extraction and User Feedback
The updated logic usesCLEAN_RETURN_DATA=$(echo "$RAW_RETURN_DATA" | grep -o '{"logs.*}')to robustly capture the JSON log output by removing any extraneous content both before and after. Additionally, the new echo statements (lines 123–125) provide clear feedback by printing the
diamondCut calldata. This improves clarity during execution.config/stargate.json (4)
24-24: New INK Endpoint in endpointV2 Section
A new entry for the "ink" network is added with the endpoint address"ink": "0xca29f3A6f966Cb2fc0dE625F8f325c0C46dbE958"Ensure this value is verified against the deployed contract details for the INK network.
65-65: New INK Token Messaging Entry
The "ink" entry is now present in the tokenMessaging section with the address"ink": "0x45f1A95A4D3f3836523F5c83673c797f4d4d263B"Confirm that this address correctly supports token messaging for INK.
235-235: New INK Composer Address
An entry for "ink" has been added in the composers section with a zero address:"ink": "0x0000000000000000000000000000000000000000"Please verify if this zero address is intentionally used as a placeholder or if a valid contract address should be configured.
284-284: New INK Router Entry
A new router entry for "ink" is introduced with the address:"ink": "0x0000000000000000000000000000000000000000"Ensure that this zero address is the appropriate value for the deployment scenario or if it needs to be updated with a concrete router contract address.
config/networks.json (1)
344-361: New INK Network Configuration Added
A comprehensive configuration block for the "ink" network has been added. The new details include:
"chainId": 57073"rpcUrl": "https://rpc-gel.inkonchain.com"- Explorer URLs (
"explorerUrl": "https://explorer.inkonchain.com"and"explorerApiUrl": "https://explorer.inkonchain.com/api/")- Multicall and safe transaction endpoints, along with
"gasZipChainId": 392These settings align with the objective of integrating support for the INK network. Please double-check that all endpoints and IDs are accurate with respect to the latest network specifications.
config/dexs.json (2)
472-477: New "ink" network category added.The new "ink" network block is introduced with four addresses. Please double-check that these addresses match the official INK deployment documentation and that they are in the expected order.
833-838: Restoration of "soneium" network category confirmed.The "soneium" category has been reintroduced with the identical four addresses as before. Verify that the duplication with the "ink" category is intentional and that downstream logic (if any) can distinguish between these two network entries.
script/deploy/_targetState.json (1)
631-633: "ink" network facet version updates verified.In the "ink" production configuration, the facets—namely
"AcrossFacetV3","AcrossFacetPackedV3", and"ReceiverAcrossV3"—are uniformly set to"1.0.0", and"ReceiverStargateV2"is updated to"1.0.0". These updates align with the intended restructuring for deploying contracts to ink. Please ensure that any related deployment scripts and health checks are updated to reference these new versions.Also applies to: 637-637
deployments/_deployments_log_file.json (25)
805-818: Ink Deployment Record for Production Version "1.0.0" (Context: Preceding DiamondLoupeFacet)
This new block correctly introduces an ink network deployment record with all required fields. Please double-check that the ADDRESS and TIMESTAMP values are accurate and conform to the expected deployment details.
1611-1625: Ink Deployment Record for Production Version "1.0.0" (Context: Under OwnershipFacet)
The ink entry is added consistently with the established JSON schema. Verify that the provided ADDRESS, OPTIMIZER_RUNS, and TIMESTAMP match your deployment records.
2416-2430: Ink Deployment Record for Production Version "1.0.0" (Context: Under an earlier contract segment)
The structure is correct and mirrors the other network entries. Ensure that the ADDRESS and other fields such as CONSTRUCTOR_ARGS and VERIFIED status are correct for this deployment.
3523-3537: Ink Deployment Record for Production Version "1.0.1" (Context: Prior to AccessManagerFacet)
The record is added with the expected format. Confirm that the version "1.0.1" is intended for this contract and that the associated deployment details are accurate.
4329-4343: Ink Deployment Record for Production Version "1.0.0" (Context: Under WithdrawFacet)
The new ink network record follows the consistent pattern. It is recommended to double-check the ADDRESS and TIMESTAMP to ensure they reflect the latest deployment information.
5121-5135: Ink Deployment Record for Production Version "1.0.0" (Context: Preceding PeripheryRegistryFacet)
The entry appears to be correctly structured. Please verify that all numeric values (e.g., OPTIMIZER_RUNS) are intentional strings and that the deployment metadata is correct.
5926-5941: Ink Deployment Record for Production Version "1.0.0" (Context: Preceding LiFiDiamond)
This ink entry is well-formed. Ensure that the address “0x6adB9BBCaAbf760f401bdA7730Aa4F6C1eF65456” and its associated metadata correctly reflect the current production deployment.
6706-6721: Ink Deployment Record for Production Version "1.0.0" with Non-Empty Constructor Args
The record includes a non-empty CONSTRUCTOR_ARGS field, which is a deviation from the other entries. Please verify that these constructor arguments are correct and intentional for this specific deployment.
8557-8572: Ink Deployment Record for Production Version "1.0.0" (Context: Preceding HopFacetOptimized)
The deployment entry is correctly added with all expected fields. Confirm that the provided values, especially the ADDRESS and TIMESTAMP, align with your deployment logs.
12089-12104: Ink Deployment Record for Production Version "1.1.0" (Context: Preceding Executor)
This entry is structured consistently with previous entries. Ensure that the CONSTRUCTOR_ARGS provided for version "1.1.0" correctly match the contract’s required initialization parameters.
13069-13084: Ink Deployment Record for Production Version "2.1.0" (Context: Under Executor)
The ink record for version "2.1.0" is added in the expected format. Please reconfirm that the ADDRESS and other parameters, including the deployment TIMESTAMP, are up to date.
13850-13865: Ink Deployment Record for Production Version "1.0.1" (Context: Under FeeCollector)
This new entry appears consistent with other network entries. As always, verify that the deployment details (ADDRESS, TIMESTAMP, etc.) are correct.
21676-21691: Ink Deployment Record for Production Version "1.2.0" (Context: Under Receiver)
The JSON segment follows the established schema. Ensure that the record’s meta fields such as OPTIMIZER_RUNS and TIMESTAMP accurately represent the production deployment for this version.
24161-24177: Ink Deployment Record for Production Version "1.1.0" (Context: Under LiFuelFeeCollector)
The entry is structured properly and includes detailed CONSTRUCTOR_ARGS. Please verify that these arguments are correct and that the overall deployment record is accurate.
24955-24971: Ink Deployment Record for Production Version "1.0.1" (Context: Under GasRebateDistributor)
The record adheres to the standard format. Double-check that the ADDRESS and TIMESTAMP are correct and that the deployment parameters have been set intentionally.
25443-25458: Ink Deployment Record for Production Version "1.0.1" (Context: Under ReceiverStargateV2)
This ink network entry is properly formatted. Verify that all data fields, especially the numeric parameters encoded as strings, align with the expected deployment values.
25779-25794: Ink Deployment Record for Production Version "1.1.0" (Context: Under LiFiDEXAggregator)
The provided details are comprehensive, including a lengthy CONSTRUCTOR_ARGS field. Please recheck that these parameters are complete and correct for this deployment version.
26413-26428: Ink Deployment Record for Production Version "1.6.0" (Context: Under EmergencyPauseFacet)
This entry introduces a higher version with an extensive set of CONSTRUCTOR_ARGS. It is recommended to verify these arguments carefully to ensure they match the intended initialization sequence.
27051-27066: Ink Deployment Record for Production Version "1.0.1" (Context: Under AcrossFacetV3)
The deployment record is correctly added with all necessary fields. Please confirm that the ADDRESS and other metadata match the expected contract deployment details.
27439-27454: Ink Deployment Record for Production Version "1.1.0" (Context: Under ReceiverAcrossV3)
The JSON entry is consistent with previous entries, including a detailed CONSTRUCTOR_ARGS field. Verify that these values correctly represent the deployed contract configuration.
27808-27823: Ink Deployment Record for Production Version "1.1.0" (Context: Under AcrossFacetPackedV3)
This block is well structured and maintains consistency with the overall deployment log format. Please double-check the deployment parameters for accuracy.
28166-28181: Ink Deployment Record for Production Version "1.2.0" (Context: Under Permit2Proxy)
The record features a lengthy CONSTRUCTOR_ARGS field that should be validated against the contract’s constructor requirements. Apart from that, the structure is correct.
28804-28819: Ink Deployment Record for Production Version "2.0.2" (Context: Under GasZipPeriphery)
This new ink entry is added following the established pattern. Please ensure the address and associated metadata are correct and reflect the actual deployment details.
29207-29225: Ink Deployment Record for Production Version "1.0.1" (Context: Under RelayFacet)
The ink network deployment record here is consistent with other entries. It is advisable to verify that the long hex string in CONSTRUCTOR_ARGS is precise and requires no further update.
29626-29641: Ink Deployment Record for Production Version "1.0.0" (Context: Under GetGasFacet)
The entry follows the JSON schema and the overall style of previous ink deployments. Ensure that the provided ADDRESS and CONSTRUCTOR_ARGS are accurate reflections of the deployed contract’s state.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
script/deploy/_targetState.json (2)
632-634: Ensure Consistency for Ink Network Contract VersionsThe entries for
"AcrossFacetV3","AcrossFacetPackedV3", and"ReceiverAcrossV3"have been updated to"1.0.0"in the ink network configuration. Please verify that these version updates are correct per the deployment specifications and that all downstream contracts or scripts consuming these values are updated accordingly.
638-638: Verify ReceiverStargateV2 Version in InkThe
"ReceiverStargateV2"entry in the ink network has been updated to"1.0.0". Confirm that this change is intentional and that all related components (such as deployment scripts and health checks) align with this updated version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
config/permit2Proxy.json(1 hunks)deployments/_deployments_log_file.json(26 hunks)deployments/ink.json(1 hunks)script/deploy/_targetState.json(2 hunks)script/tasks/diamondUpdateFacet.sh(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- script/tasks/diamondUpdateFacet.sh
- deployments/ink.json
🧰 Additional context used
🧠 Learnings (1)
script/deploy/_targetState.json (1)
Learnt from: ezynda3
PR: lifinance/contracts#861
File: script/deploy/_targetState.json:1453-1483
Timestamp: 2024-11-21T08:24:53.059Z
Learning: In `script/deploy/_targetState.json`, for the `abstract` network configuration, `ReceiverStargateV2` is correctly set to version `1.0.1`.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: run-unit-tests
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: generate-tag
🔇 Additional comments (28)
config/permit2Proxy.json (1)
19-19: New INK Network Entry VerificationThe addition of the
"ink"key with the address"0x000000000022D473030F116dDEE9F6B43aC78BA3"aligns with how other networks are configured in this file. Please verify that this address is correct, reflecting the actual permit2 proxy contract deployed on the INK network—especially since the same address is used for several networks.deployments/_deployments_log_file.json (26)
805-819: Ink Deployment Record for Production Version "1.0.0" Added
A new deployment record under the "ink" key is introduced with the production configuration for version "1.0.0". All the required fields (ADDRESS, OPTIMIZER_RUNS, TIMESTAMP, CONSTRUCTOR_ARGS, SALT, and VERIFIED) are present. Please verify that the provided contract address is correctly checksummed and that the timestamp reflects the accurate deployment time.
1611-1626: Ink Deployment Log for OwnershipFacet Added
The new "ink" deployment entry (production, version "1.0.0") has been integrated under what appears to be the OwnershipFacet configuration. The structure and field values are consistent. Ensure that the ADDRESS and other deployment details match the intended deployment target for this facet.
2416-2427: Ink Record Integration for Current Facet
An ink deployment record for production version "1.0.0" with the address "0x42e4Ef53e8d905A5D02CC12b8C60D27800F76121" is added. The JSON structure is consistent, so please double-check that the deployment details align with the expected outcomes for this facet.
3523-3537: Ink Record for AccessManagerFacet Added
A new ink record under production with version "1.0.1" has been introduced. The entry follows the standard format. It is advisable to confirm that the version change (from “1.0.0” in other places to “1.0.1” here) is intended and that the deployment parameters (e.g., optimizer runs, timestamp) are correct.
4329-4343: Ink Entry for WithdrawFacet Added
This addition brings an ink deployment record for production version "1.0.0" under WithdrawFacet. The fields provided appear in the correct format. A quick verification of the ADDRESS and associated metadata is recommended to ensure consistency with other deployments.
5121-5135: Ink Deployment Log Update for PeripheryRegistryFacet
The addition of an ink record for production version "1.0.0" is detected. The record’s structure is compliant with the rest of the file. No issues were found, but please verify that the recorded details are aligned with your deployment tracking standards.
5926-5940: Ink Deployment Details for LiFiDiamond Added
A new ink deployment record has been added for production version "1.0.0" within the LiFiDiamond configuration. All the data fields appear correctly formatted; however, ensure that the deployment metadata such as the timestamp and the contract address meet your audit requirements.
6706-6720: New Ink Configuration for LiFiDiamondImmutable
This hunk introduces an ink deployment record for production version "1.0.0" under what seems to be LiFiDiamondImmutable. Note that the "CONSTRUCTOR_ARGS" field is non-trivial here; please validate that the concatenated data represents the correct initialization parameters.
8557-8571: Ink Record Inserted Before HopFacetOptimized
The new ink record with production version "1.0.0" is positioned just before the "HopFacetOptimized" key. This addition appears consistent with the recurring structure. Kindly ensure that the deployment details and address are accurate, in line with the other facets.
12089-12103: Ink Deployment Configuration for Executor Facet
The entry adds an ink deployment record for production version "1.1.0" complete with non-empty constructor arguments. It would be beneficial to verify that the provided initialization parameters are correct and conform to the intended deployment configuration.
13069-13083: Ink Deployment Record in FeeCollector Context Added
A new ink record for production version "2.1.0" is introduced with detailed and concatenated constructor arguments. Please double-check the long hex string in "CONSTRUCTOR_ARGS" to ensure its correctness, as this is critical during audits.
13850-13864: Ink Deployment Record for Receiver Added
An ink record with production version "1.0.1" is appended under the Receiver configuration. All necessary fields are provided and formatted correctly. Ensure that the contract address and deployment timestamp are validated against your records.
21676-21690: Ink Record for LiFuelFeeCollector Added
The deployment record for production version "1.2.0" under LiFuelFeeCollector is now included. The deployment metadata appears consistent; please verify that the ADDRESS provided is correctly cross-checked with other deployment records.
24161-24175: Ink Deployment Log Update for GasRebateDistributor
A new ink record for production version "1.1.0" is added under the GasRebateDistributor section. The structure and field-values are uniform with the rest of the records. Consider validating the length and format of the "CONSTRUCTOR_ARGS", if applicable.
24955-24969: Ink Deployment Record for StargateFacetV2 Added
A new ink deployment entry for production version "1.0.1" is incorporated. Please ensure that the deployment details, especially the address and version tag, are correctly synced with your deployment strategy.
25443-25457: Ink Entry Integration for ReceiverStargateV2
An ink record with production version "1.0.1" is added here. The record maintains consistency with other entries. If applicable, verify that this facet’s deployment parameters match the intended configuration.
25779-25793: Ink Deployment Record for LiFiDEXAggregator Added
This hunk introduces a new ink record for production version "1.1.0" with multiple concatenated parameters in "CONSTRUCTOR_ARGS". It is important to confirm that these parameters correctly initialize the contract as intended.
26413-26427: Ink Record Addition for EmergencyPauseFacet
The ink deployment record for production version "1.6.0" has been added, featuring comprehensive constructor arguments. Please review these parameters carefully to ensure they accurately reflect the intended deployment configuration for emergency pause functionality.
27051-27065: Ink Deployment Log Update for AcrossFacetV3
A new entry for production version "1.0.1" is now part of the AcrossFacetV3 deployment logs. The structure is standard; still, a verification of the hex values in the constructor arguments is recommended to catch any potential misconfiguration.
27439-27453: Ink Record for ReceiverAcrossV3 Added
This addition appends an ink deployment record for production version "1.1.0" under ReceiverAcrossV3. All fields are coordinated with the overall schema. Please ensure that the configuration parameters and contract address are accurate according to your deployment audits.
27808-27822: Ink Deployment Record for AcrossFacetPackedV3 Added
A new ink record for production version "1.1.0" is introduced with concatenated parameters in the "CONSTRUCTOR_ARGS". It is advisable to validate these parameters to ensure they correctly initialize the packed facet deployment.
28166-28180: Ink Deployment Addition for Permit2Proxy Added
The ink record for production version "1.2.0" under the Permit2Proxy configuration is added correctly. All required fields are present and well-formed. A final verification of the constructor arguments and address is recommended for absolute certainty.
28402-28416: Ink Record Insertion for GasZipFacet Added
A new ink deployment record for production version "1.0.2" under GasZipFacet is included. The standard field set is maintained. Please confirm that the contract address and other deployment details are verified.
28818-28832: Ink Deployment Log Update for GasZipPeriphery Added
The addition comprises an ink record for production version "2.0.2". All fields, such as TIMESTAMP and OPTIMIZER_RUNS, appear consistent with other entries. Ensure that these details reflect the intended gas optimization deployment for the ink network.
29224-29238: Ink Deployment Record for RelayFacet Added
A new ink record for production version "1.0.1" under RelayFacet is now present. The "CONSTRUCTOR_ARGS" appears as a complex hex string; please double-check that it correctly represents the initialization parameters and does not omit any necessary data.
29640-29654: Ink Deployment Record for GetGasFacet Added
The record for production version "1.0.0" in the GetGasFacet section has been added successfully. The deployment details are complete and follow the established format. A final verification of the contract address and parameters against internal deployment records is recommended.script/deploy/_targetState.json (1)
468-468: Confirm Change for SquidFacet in FantomIn the fantom network section, the
"SquidFacet"entry is now marked with an update to"1.0.0". Please confirm that this update is deliberate and that it does not conflict with expected versions in other network configurations.
Which Jira task belongs to this PR?
https://lifi.atlassian.net/browse/LF-12287
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)