This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
Remove _.isPlainObject calls in divert.js (x2) #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
added a commit
that referenced
this pull request
Feb 27, 2019
As noted in: #163 This function was duplicated almost verbatim in two packages. Centralize it in "liferay-theme-tasks" as the first step towards unmonorepoization discussed in: #164 Eventually, we might only have two packages: - generator-liferay-theme (needs to be independent, so yeoman can find it). - liferay-theme-tasks (effectively the public "API" of the SDK). Test plan: `yarn test` and `yo ./packages/generator-liferay-theme` (works, apart from expected failure due to us not having published liferay-theme-deps-7.2 to NPM yet).
Also worth noting: these two modules are almost exact duplicates. As a follow-up I am going to look at de-duping them. Related: #141
Required but never used.
wincent
added a commit
that referenced
this pull request
Feb 27, 2019
As noted in: #163 This function was duplicated almost verbatim in two packages. Centralize it in "liferay-theme-tasks" as the first step towards unmonorepoization discussed in: #164 Eventually, we might only have two packages: - generator-liferay-theme (needs to be independent, so yeoman can find it). - liferay-theme-tasks (effectively the public "API" of the SDK). Test plan: `yarn test` and `yo ./packages/generator-liferay-theme` (works, apart from expected failure due to us not having published liferay-theme-deps-7.2 to NPM yet).
|
#165 is the follow-up to this, building on top of it (which, due to the way GitHub works, means that the commits are duplicated in that one). |
wincent
force-pushed
the
wincent/remove-is-plain-object
branch
from
8a07aee
to
d4b4e40
Compare
|
Just started reviewing :) |
julien
approved these changes
Feb 27, 2019
wincent
added a commit
that referenced
this pull request
Feb 27, 2019
As noted in: #163 This function was duplicated almost verbatim in two packages. Centralize it in "liferay-theme-tasks" as the first step towards unmonorepoization discussed in: #164 Eventually, we might only have two packages: - generator-liferay-theme (needs to be independent, so yeoman can find it). - liferay-theme-tasks (effectively the public "API" of the SDK). Test plan: `yarn test` and `yo ./packages/generator-liferay-theme` (works, apart from expected failure due to us not having published liferay-theme-deps-7.2 to NPM yet).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also worth noting: these two modules are almost exact duplicates. As a follow-up I am going to look at de-duping them.
Related: #141