Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing contents property to legend option #494

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented Jan 30, 2018

No description provided.

@julien
Copy link
Contributor Author

julien commented Jan 30, 2018

@Robert-Frampton if you have time to review this, it'd be much appreciated.
You can have a look at #459 for more context.

Thanks.

legend: {
contents: {
bindto: '.pie-legend',
template(title, color) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @julien

Not sure if this is applicable or not, but should we consider bringing this svg template over to Clay somehow so that it can be leveraged? Maybe even if it was just provided as a utility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it sounds like a good idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robert-Frampton, should I close this pull request until we have an idea of how we want to include this svg template?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @julien, since this is adding missing config, let's merge it and then do the abstraction in another issue.

@@ -889,11 +889,15 @@ ChartBase.STATE = {
/**
* Legend display options.
* @instance
* @memberof ChartBase
* @memberof ChartBas

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks

@robframpton robframpton merged commit 85bc1ad into liferay:develop Feb 1, 2018
@julien
Copy link
Contributor Author

julien commented Feb 1, 2018

@Robert-Frampton ok thanks!

@julien julien deleted the chart-legend-option branch February 7, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants