-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing contents property to legend option #494
Conversation
@Robert-Frampton if you have time to review this, it'd be much appreciated. Thanks. |
legend: { | ||
contents: { | ||
bindto: '.pie-legend', | ||
template(title, color) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @julien
Not sure if this is applicable or not, but should we consider bringing this svg template over to Clay somehow so that it can be leveraged? Maybe even if it was just provided as a utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it sounds like a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robert-Frampton, should I close this pull request until we have an idea of how we want to include this svg template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @julien, since this is adding missing config, let's merge it and then do the abstraction in another issue.
@@ -889,11 +889,15 @@ ChartBase.STATE = { | |||
/** | |||
* Legend display options. | |||
* @instance | |||
* @memberof ChartBase | |||
* @memberof ChartBas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks
@Robert-Frampton ok thanks! |
No description provided.