Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClaySticker must accept any style value #721

Closed
julien opened this issue Mar 13, 2018 · 2 comments
Closed

ClaySticker must accept any style value #721

julien opened this issue Mar 13, 2018 · 2 comments
Assignees
@julien
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code

Comments

@julien
Copy link
Contributor

julien commented Mar 13, 2018

At the moment ClaySticker only accepts a list of defined styles and it should accept any value.
@julien julien self-assigned this Mar 13, 2018
@carloslancha carloslancha changed the title Fix styles in ClaySticker ClaySticker must accept any style value Mar 13, 2018
julien pushed a commit to julien/clay that referenced this issue Mar 13, 2018
ClaySticker should accept any value for style
bcff302 
Fixes liferay#721
marcoscv-work pushed a commit to marcoscv-work/clay that referenced this issue Mar 13, 2018
@marcoscv
Site: (liferay#721) User icon to sticker-circle
3c68040
marcoscv-work pushed a commit to marcoscv-work/clay that referenced this issue Mar 14, 2018
@marcoscv
User icon to sticker-circle comment | Fixes: liferay#721
9b4e37e
jbalsas added a commit that referenced this issue Mar 14, 2018
@jbalsas
Merge pull request #724 from marcoscv-work/721
1e4caad 
Site: (#721) User icon to sticker-circle
@carloslancha carloslancha reopened this Mar 19, 2018
@matuzalemsteles matuzalemsteles added type: enhancement Issues that are open to bring improvements or refinement of code comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Nov 23, 2018
@matuzalemsteles
Copy link
Member

Hey guys, are we still in need of this?

@diegonvs
Copy link
Contributor

diegonvs commented Mar 18, 2019 •
edited
Loading

Closing due inactivity, don't hesitate to open when have a question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien julien

Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@julien @carloslancha @diegonvs @matuzalemsteles