Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled attribute markup is incorrect for button #522

Closed
mwilliams2014 opened this issue Feb 7, 2018 · 0 comments
Closed

Disabled attribute markup is incorrect for button #522

mwilliams2014 opened this issue Feb 7, 2018 · 0 comments
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@mwilliams2014
Copy link
Contributor

mwilliams2014 commented Feb 7, 2018 •
edited
Loading

In the Clay Sample portlet, when you add a clay button taglib with attribute disabled="true", the generated markup is disabledtype=button, so the button is not disabled. Tested on https://liferay-master.wedeploy.io/
@jbalsas jbalsas added the type: bug Issues reporting that Component is not doing what should be done label Feb 8, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 15, 2018
@matuzalemsteles
Regen snapshots | Fixes liferay#522
b36461b
@matuzalemsteles matuzalemsteles mentioned this issue Feb 15, 2018
Merged
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 15, 2018
@matuzalemsteles
Rename attribute disabled="true" for disabled="disabled" | Fixes life…
03d8f02 
…ray#522
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 15, 2018
@matuzalemsteles
Regen snapshots | Fixes liferay#522
209baa6
carloslancha added a commit that referenced this issue Feb 15, 2018
@carloslancha
Merge pull request #561 from matuzalemsteles/issue-522
d183409 
Adds disabled="disabled" to force your render separate from other attributes | Fixes #522
@carloslancha carloslancha added the status: next-release Issues that will enter into the next release label Feb 15, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Adds disabled="true" to force your render separate from other attribu…
5acca00 
…tes | Fixes liferay#522
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Regen snapshots | Fixes liferay#522
46f4250
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Rename attribute disabled="true" for disabled="disabled" | Fixes life…
8896368 
…ray#522
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Regen snapshots | Fixes liferay#522
03f438e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbalsas @carloslancha @mwilliams2014