Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav nested has lost its previous styles #405

Closed
marcoscv-work opened this issue Jan 9, 2018 · 3 comments
Closed

Nav nested has lost its previous styles #405

marcoscv-work opened this issue Jan 9, 2018 · 3 comments
Labels

Comments

@marcoscv-work
Copy link
Member

The styles are defined here:
https://lexicondesign.io/docs/patterns/Navigation/verticalNav.html
image

Currently and from Clay beta 4 it looks:
image

There is an issue in Liferay portal:
https://issues.liferay.com/browse/LPS-76907

@pat270
Copy link
Member

pat270 commented Jan 9, 2018

Hey @marcoscv-work,
Bootstrap 4 removed active styling from base navs (http://getbootstrap.com/docs/4.0/components/navs/#base-nav). Nav Nested is now a base component for creating nested navigations. We will need to add colors and active styles to the compatibility layer.

Lexicon 2 also reworked the pattern so that it collapses in mobile (https://lexicondesign.io/docs/patterns/Navigation/verticalNav.html). I ended up creating a menubar component (http://pat270.github.io/lexicon/content/menu-bar-vertical/) to make it happen. There's only one type right now where it collapses at 767px. If we need one that doesn't collapse I can add one, I just didn't see the pattern in any of the Lexicon documents.

@pat270 pat270 added the 2.x label Jan 9, 2018
@jbalsas
Copy link
Contributor

jbalsas commented Jan 10, 2018

I assume this is also the problem showed in https://issues.liferay.com/browse/LPS-76907 where we're likely better off updating the markup.

Could either of you take a look?

@marcoscv-work
Copy link
Member Author

Hey guys,

Lexicon guys have reviewed the component and they think is correct, so we would only need to create the clay component, add this nested navigation component to claycss.com and update it in portal.

Thanks @pat270 !

/cc @victorvalle

marcoscv-work added a commit that referenced this issue Feb 28, 2018
Update: (Closes #405) Mixin `clay-nav-variant` add more configuration…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants