Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win #11

Closed
wants to merge 36 commits into from
Closed

Win #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
1bc8a60
ci: check out submodules for verification build (#1549)
lidavidm Feb 15, 2024
37026a9
test(csharp/test/Drivers/Interop/Snowflake): Numeric operator tests f…
birschick-bq Feb 15, 2024
adfb70a
feat(java/driver/flight-sql): implement getObjects (#1517)
jduo Feb 18, 2024
dfa2a4c
chore(csharp): bump xunit from 2.6.6 to 2.7.0 in /csharp (#1556)
dependabot[bot] Feb 19, 2024
ed73fa6
chore(csharp): bump xunit.runner.visualstudio from 2.5.6 to 2.5.7 in …
dependabot[bot] Feb 19, 2024
9b90c91
chore(java/driver/jdbc): bump org.postgresql:postgresql from 42.4.3 t…
dependabot[bot] Feb 21, 2024
6c06ae2
chore: update changelog and bump versions (#1560)
lidavidm Feb 22, 2024
fa8498f
fix(csharp/src/Drivers/BigQuery): return null on GetValue exception (…
davidhcoe Feb 22, 2024
aeabeac
test(go/adbc/driver/snowflake): fix flaky integration tests (#1561)
zeroshade Feb 23, 2024
1c9912a
chore(csharp): bump Google.Cloud.BigQuery.V2 from 3.5.0 to 3.6.0 in /…
dependabot[bot] Feb 26, 2024
f26ca92
chore(csharp): bump Google.Cloud.BigQuery.Storage.V1 from 3.11.0 to 3…
dependabot[bot] Feb 26, 2024
b29e4a9
fix(csharp/src/Client/SchemaConverter): add check for keys on precisi…
davidhcoe Feb 26, 2024
d55e8ab
test(python/adbc_driver_flightsql): test incremental execution (#1575)
lidavidm Mar 1, 2024
62b0728
docs(java): show how to build with ErrorProne/Checker Framework (#1578)
lidavidm Mar 1, 2024
d9d66b2
feat(c/driver/common): Add minimal C++ driver framework (#1539)
paleolimbot Mar 1, 2024
2353563
feat(python): react to SIGINT in more places (#1579)
lidavidm Mar 1, 2024
56e96e2
ci: configure env vars for CI in .env file (#1580)
lidavidm Mar 1, 2024
bcbc161
feat(go/adbc/driver/flightsql): reflect gRPC status in vendor code (#…
lidavidm Mar 1, 2024
d962961
feat(go/adbc/driver/flightsql): expose FlightInfo during polling (#1582)
lidavidm Mar 1, 2024
bf42dc6
fix(go/adbc/drivermgr): don't call potentially nil pointer (#1586)
lidavidm Mar 4, 2024
e2be3f1
feat(go/adbc/driver/flightsql): support reuse-connection location (#1…
lidavidm Mar 7, 2024
3e3277d
test(go/adbc/driver/flightsql): try to fix flaky test (#1596)
lidavidm Mar 7, 2024
a3579ff
test(go/adbc/driver/snowflake): properly skip tests w/o creds (#1598)
lidavidm Mar 7, 2024
0b50e4f
build(c): fix warnings for MSVC (#1600)
lidavidm Mar 8, 2024
0ca0f9e
fix(python): correct typechecking error (#1604)
lidavidm Mar 8, 2024
1cbfb2f
feat(go/adbc/driver/flightsql): support session options (#1597)
lidavidm Mar 11, 2024
6e8c03e
chore(csharp): bump Apache.Arrow from 15.0.0 to 15.0.1 in /csharp (#1…
dependabot[bot] Mar 11, 2024
7b185fe
chore(csharp): bump Google.Cloud.BigQuery.V2 from 3.6.0 to 3.7.0 in /…
dependabot[bot] Mar 11, 2024
f4d0a7d
chore(ci): fix verification jobs (#1613)
lidavidm Mar 12, 2024
27d62c3
chore(ci): fix wheel builds (#1612)
lidavidm Mar 12, 2024
8409422
docs: add R packages to post-release checklist (#1614)
lidavidm Mar 12, 2024
9f991ad
build(c): set -g3 in debug/relwithdebuginfo builds (#1609)
lidavidm Mar 13, 2024
56ca3b1
chore(go): update dependencies, fix vulnerabilities (#1615)
zeroshade Mar 13, 2024
3c87d77
ci: work around ASAN issue (#1618)
lidavidm Mar 15, 2024
e1d27c7
refactor(c/driver/sqlite): port to driver base
lidavidm Mar 8, 2024
3815bf5
hmm
lidavidm Mar 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ARCH_CONDA_FORGE=linux_64_
JDK=8
MANYLINUX=2014
MAVEN=3.5.4
PYTHON=3.10
PYTHON=3.8
GO=1.19.5
ARROW_MAJOR_VERSION=14
DOTNET=7.0
Expand All @@ -40,4 +40,20 @@ DOTNET=7.0
# ci/scripts/install_vcpkg.sh script. Keep in sync with apache/arrow .env.
# When updating, also update the docs, which list the version of libpq/SQLite
# that vcpkg (and hence our wheels) ship
VCPKG="501db0f17ef6df184fcdbfbe0f87cde2313b6ab1"
VCPKG="a42af01b72c28a8e1d7b48107b33e4f286a55ef6"

# These are used to tell tests where to find services for integration testing.
# They are valid if the services are started with the docker-compose config.
ADBC_DREMIO_FLIGHTSQL_PASS=dremio123
ADBC_DREMIO_FLIGHTSQL_URI=grpc+tcp://localhost:32010
ADBC_DREMIO_FLIGHTSQL_USER=dremio
ADBC_JDBC_MSSQL_URL=localhost:1433
ADBC_JDBC_MSSQL_USER=SA
ADBC_JDBC_MSSQL_PASSWORD=Password1!
ADBC_JDBC_POSTGRESQL_URL=localhost:5432/postgres
ADBC_JDBC_POSTGRESQL_USER=postgres
ADBC_JDBC_POSTGRESQL_PASSWORD=password
ADBC_JDBC_POSTGRESQL_DATABASE=postgres
ADBC_POSTGRESQL_TEST_URI=postgresql://localhost:5432/postgres?user=postgres&password=password
ADBC_SQLITE_FLIGHTSQL_URI=grpc+tcp://localhost:8080
ADBC_TEST_FLIGHTSQL_URI=grpc+tcp://localhost:41414
70 changes: 27 additions & 43 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ jobs:
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Build DuckDB Integration Tests
shell: bash -l {0}
env:
Expand Down Expand Up @@ -135,55 +139,45 @@ jobs:
check-latest: true
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Start SQLite server and Dremio
shell: bash -l {0}
run: |
docker-compose up -d flightsql-test flightsql-sqlite-test dremio dremio-init
docker compose up --detach flightsql-test flightsql-sqlite-test dremio dremio-init
cat .env | grep -v -e '^#' | awk NF | tee -a $GITHUB_ENV

- name: Build FlightSQL Driver
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
BUILD_DRIVER_MANAGER: "1"
run: |
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
- name: Test FlightSQL Driver against Dremio and SQLite
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
ADBC_DREMIO_FLIGHTSQL_URI: "grpc+tcp://localhost:32010"
ADBC_DREMIO_FLIGHTSQL_USER: "dremio"
ADBC_DREMIO_FLIGHTSQL_PASS: "dremio123"
ADBC_SQLITE_FLIGHTSQL_URI: "grpc+tcp://localhost:8080"
ADBC_TEST_FLIGHTSQL_URI: "grpc+tcp://localhost:41414"
run: |
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/cpp_test.sh "$(pwd)/build"
- name: Build Python Flight SQL driver
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
BUILD_DRIVER_MANAGER: "1"
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
- name: Test Python Flight SQL driver against Dremio
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
ADBC_DREMIO_FLIGHTSQL_URI: "grpc+tcp://localhost:32010"
ADBC_DREMIO_FLIGHTSQL_USER: "dremio"
ADBC_DREMIO_FLIGHTSQL_PASS: "dremio123"
ADBC_TEST_FLIGHTSQL_URI: "grpc+tcp://localhost:41414"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build"
- name: Stop SQLite server and Dremio
shell: bash -l {0}
run: |
docker-compose down
docker compose down

postgresql:
name: "PostgreSQL Integration Tests"
Expand Down Expand Up @@ -216,30 +210,31 @@ jobs:
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt
pip install pytest-error-for-skips
- name: Build PostgreSQL Driver
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
run: |
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
- name: Build Python PostgreSQL Driver
sudo sysctl vm.mmap_rnd_bits=28
- name: Build PostgreSQL Driver
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
BUILD_DRIVER_POSTGRESQL: "1"
run: |
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
- name: Configure Integration Env Vars
shell: bash -l {0}
run: |
cat .env | grep -v -e '^#' | awk NF | tee -a $GITHUB_ENV
echo "ADBC_USE_ASAN=ON" >> $GITHUB_ENV
echo "ADBC_USE_UBSAN=ON" >> $GITHUB_ENV

- name: Test PostgreSQL Driver - postgres 11
shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
ADBC_USE_ASAN: "ON"
ADBC_USE_UBSAN: "ON"
ADBC_POSTGRESQL_TEST_URI: "postgresql://localhost:5432/postgres?user=postgres&password=password"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
env POSTGRES_VERSION=11 docker compose up --wait --detach postgres-test
Expand All @@ -251,9 +246,6 @@ jobs:
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
ADBC_USE_ASAN: "ON"
ADBC_USE_UBSAN: "ON"
ADBC_POSTGRESQL_TEST_URI: "postgresql://localhost:5432/postgres?user=postgres&password=password"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
env POSTGRES_VERSION=12 docker compose up --wait --detach postgres-test
Expand All @@ -265,9 +257,6 @@ jobs:
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
ADBC_USE_ASAN: "ON"
ADBC_USE_UBSAN: "ON"
ADBC_POSTGRESQL_TEST_URI: "postgresql://localhost:5432/postgres?user=postgres&password=password"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
env POSTGRES_VERSION=13 docker compose up --wait --detach postgres-test
Expand All @@ -279,9 +268,6 @@ jobs:
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
ADBC_USE_ASAN: "ON"
ADBC_USE_UBSAN: "ON"
ADBC_POSTGRESQL_TEST_URI: "postgresql://localhost:5432/postgres?user=postgres&password=password"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
env POSTGRES_VERSION=14 docker compose up --wait --detach postgres-test
Expand All @@ -293,9 +279,6 @@ jobs:
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
ADBC_USE_ASAN: "ON"
ADBC_USE_UBSAN: "ON"
ADBC_POSTGRESQL_TEST_URI: "postgresql://localhost:5432/postgres?user=postgres&password=password"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
env POSTGRES_VERSION=15 docker compose up --wait --detach postgres-test
Expand All @@ -307,9 +290,6 @@ jobs:
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
ADBC_USE_ASAN: "ON"
ADBC_USE_UBSAN: "ON"
ADBC_POSTGRESQL_TEST_URI: "postgresql://localhost:5432/postgres?user=postgres&password=password"
PYTEST_ADDOPTS: "--error-for-skips"
run: |
env POSTGRES_VERSION=16 docker compose up --wait --detach postgres-test
Expand Down Expand Up @@ -347,6 +327,10 @@ jobs:
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- uses: actions/setup-go@v5
with:
go-version: 1.19.13
Expand Down
14 changes: 4 additions & 10 deletions .github/workflows/java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,9 @@ jobs:
- name: Start test services
shell: bash -l {0}
run: |
docker compose up -d --wait flightsql-sqlite-test mssql-test postgres-test
docker compose up --detach --wait flightsql-sqlite-test mssql-test postgres-test
cat .env | grep -v -e '^#' | awk NF | tee -a $GITHUB_ENV
- name: Build/Test
env:
ADBC_SQLITE_FLIGHTSQL_URI: "grpc+tcp://localhost:8080"
ADBC_JDBC_MSSQL_URL: "localhost:1433"
ADBC_JDBC_MSSQL_USER: "SA"
ADBC_JDBC_MSSQL_PASSWORD: "Password1!"
ADBC_JDBC_POSTGRESQL_URL: "localhost:5432/postgres"
ADBC_JDBC_POSTGRESQL_USER: "postgres"
ADBC_JDBC_POSTGRESQL_PASSWORD: "password"
run: |
cd java
mvn install
Expand Down Expand Up @@ -104,4 +97,5 @@ jobs:
--add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED
HERE
mvn -P errorprone install
# Our linters are compile-time, no point re-running tests
mvn -P errorprone install -DskipTests
42 changes: 36 additions & 6 deletions .github/workflows/native-unix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ jobs:
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28

- name: Build
shell: bash -l {0}
Expand Down Expand Up @@ -269,6 +274,11 @@ jobs:
'arrow-c-glib>=10.0.1' \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_glib.txt
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28

- uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -306,6 +316,12 @@ jobs:
check-latest: true
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28

- name: Install staticcheck
run: go install honnef.co/go/tools/cmd/staticcheck@v0.3.3
- name: Go Build
Expand Down Expand Up @@ -354,6 +370,12 @@ jobs:
miniforge-version: latest
use-only-tar-bz2: false
use-mamba: true
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28

- name: Install Dependencies
shell: bash -l {0}
run: |
Expand Down Expand Up @@ -439,6 +461,11 @@ jobs:
python=${{ matrix.python }} \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
- uses: actions/setup-go@v5
with:
go-version: 1.19.13
Expand Down Expand Up @@ -547,6 +574,11 @@ jobs:
python=${{ matrix.python }} \
--file ci/conda_env_docs.txt \
--file ci/conda_env_python.txt
- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
- uses: actions/download-artifact@v3
with:
name: driver-manager-${{ matrix.os }}
Expand All @@ -572,18 +604,16 @@ jobs:
retention-days: 2
path: |
docs/build/html
- name: Configure Integration Env Vars
shell: bash -l {0}
run: |
cat .env | grep -v -e '^#' | awk NF | tee -a $GITHUB_ENV
- name: Test Recipes (C++)
shell: bash -l {0}
run: |
./ci/scripts/cpp_recipe.sh $(pwd) ~/local build/recipe
- name: Test Recipes (Python)
shell: bash -l {0}
env:
ADBC_POSTGRESQL_TEST_URI: "postgres://localhost:5432/postgres?user=postgres&password=password"
ADBC_DREMIO_FLIGHTSQL_URI: "grpc+tcp://localhost:32010"
ADBC_DREMIO_FLIGHTSQL_USER: "dremio"
ADBC_DREMIO_FLIGHTSQL_PASS: "dremio123"
ADBC_SQLITE_FLIGHTSQL_URI: "grpc+tcp://localhost:8080"
run: |
docker compose up --detach --wait dremio dremio-init flightsql-sqlite-test postgres-test
pytest -vvs docs/source/tests/
10 changes: 10 additions & 0 deletions .github/workflows/nightly-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
submodules: recursive

- name: Prepare version
shell: bash
Expand Down Expand Up @@ -133,9 +135,16 @@ jobs:
miniforge-version: latest
use-mamba: true

- name: Work around ASAN issue (GH-1617)
shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28

- name: Verify
if: matrix.os != 'windows-latest'
env:
CI: "false"
REPOSITORY: ${{ github.repository }}
TEST_DEFAULT: "0"
TEST_SOURCE: "1"
Expand All @@ -149,6 +158,7 @@ jobs:
if: matrix.os == 'windows-latest'
shell: pwsh
env:
CI: "false"
REPOSITORY: ${{ github.repository }}
TEST_DEFAULT: "0"
TEST_SOURCE: "1"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Build
shell: bash
run: |
docker-compose run docs
docker compose run docs
- name: Archive docs
uses: actions/upload-artifact@v3
with:
Expand Down
Loading
Loading