Skip to content

Commit

Permalink
ci: update PR title validity regex
Browse files Browse the repository at this point in the history
  • Loading branch information
lidavidm committed Apr 19, 2024
1 parent 3a86ec1 commit b308853
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/dev_pr/title_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def matches_commit_format(root: Path, title: str) -> typing.List[str]:
delimiter = "!?:"
subject = " (.+)"
commit = re.compile(f"^{commit_type}{scope}{delimiter}{subject}$")
valid_component = re.compile(r"^[a-zA-Z0-9_/\-]+$")
valid_component = re.compile(r"^[a-zA-Z0-9_/\-\.]+$")

m = commit.match(title)
if m is None:
Expand All @@ -75,8 +75,8 @@ def matches_commit_format(root: Path, title: str) -> typing.List[str]:
)
elif not valid_component.match(component):
reasons.append(
"Invalid component: must be alphanumeric with "
f"dashes, slashes, and underscores: {component}"
"Invalid component: must be alphanumeric "
f"plus [.-/]: {component}"
)
elif component != "format" and not Path(component).exists():
reasons.append(
Expand Down

0 comments on commit b308853

Please sign in to comment.