ci: build wheels with debug info

Fixes apache#1583.
lidavidm · Mar 7, 2024 · 5bc6490 · 5bc6490
1 parent a3579ff
commit 5bc6490
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/ci/scripts/python_util.sh b/ci/scripts/python_util.sh
@@ -25,7 +25,7 @@ function build_drivers {
     local -r source_dir="$1"
     local -r build_dir="$2/${VCPKG_ARCH}"
 
-    : ${CMAKE_BUILD_TYPE:=release}
+    : ${CMAKE_BUILD_TYPE:=RelWithDebInfo}
     : ${CMAKE_UNITY_BUILD:=ON}
     : ${CMAKE_GENERATOR:=Ninja}
     : ${VCPKG_ROOT:=/opt/vcpkg}

diff --git a/ci/scripts/python_wheel_unix_build.sh b/ci/scripts/python_wheel_unix_build.sh
@@ -88,6 +88,9 @@ check_visibility $ADBC_SNOWFLAKE_LIBRARY
 # Get the latest pip so we have in-tree-build by default
 python -m pip install --upgrade pip auditwheel cibuildwheel delocate setuptools wheel
 
+# Build with Cython debug info
+export ADBC_BUILD_TYPE="debug"
+
 for component in $COMPONENTS; do
     pushd ${source_dir}/python/$component
 

diff --git a/ci/scripts/python_wheel_windows_build.bat b/ci/scripts/python_wheel_windows_build.bat
@@ -22,8 +22,9 @@ set build_dir=%2
 
 echo "=== (%PYTHON_VERSION%) Building ADBC libpq driver ==="
 
-set CMAKE_BUILD_TYPE=release
-set CMAKE_GENERATOR=Visual Studio 15 2017 Win64
+set CMAKE_BUILD_TYPE=RelWithDebInfo
+set CMAKE_GENERATOR=Visual Studio 17 2022
+set CMAKE_GENERATOR_PLATFORM=x64
 set CMAKE_UNITY_BUILD=ON
 set VCPKG_FEATURE_FLAGS=-manifests
 set VCPKG_TARGET_TRIPLET=x64-windows-static
@@ -38,6 +39,7 @@ pushd %build_dir%
 
 cmake ^
       -G "%CMAKE_GENERATOR%" ^
+      -A "%CMAKE_GENERATOR_PLATFORM%" ^
       -DADBC_BUILD_SHARED=ON ^
       -DADBC_BUILD_STATIC=OFF ^
       -DCMAKE_BUILD_TYPE=%CMAKE_BUILD_TYPE% ^
@@ -59,6 +61,9 @@ set ADBC_POSTGRESQL_LIBRARY=%build_dir%\bin\adbc_driver_postgresql.dll
 set ADBC_SQLITE_LIBRARY=%build_dir%\bin\adbc_driver_sqlite.dll
 set ADBC_SNOWFLAKE_LIBRARY=%build_dir%\bin\adbc_driver_snowflake.dll
 
+# Build with Cython debug info
+set ADBC_BUILD_TYPE=debug
+
 popd
 
 python -m pip install --upgrade pip delvewheel wheel || exit /B 1