Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If file not found when visiting link, create file where appropriate #63

Merged

Conversation

jayemar
Copy link
Collaborator

@jayemar jayemar commented Jul 23, 2023

Creates new function to check whether file matching requested path already exists, and if not, creates the file in either inbox or the root directory and add the file to the cache.

Closes #62

@licht1stein
Copy link
Owner

I think at this point you can just make PRs without bothering with issued :)

@jayemar
Copy link
Collaborator Author

jayemar commented Jul 26, 2023

Alright, sounds good to me!

@licht1stein
Copy link
Owner

Sorry got distracted a bit.

@licht1stein licht1stein merged commit d4ebbfa into licht1stein:master Aug 8, 2023
5 checks passed
mastro35 added a commit to mastro35/obsidian.el that referenced this pull request Sep 15, 2023
Commit d4ebbfa for issue licht1stein#63 use the f-exists-p function that doesn't exists in standard Emacs but only in f.el library. Since this is simply an alias to file-exists-p, let's use this last one so that we don't need to depend from f.el.
@jayemar jayemar deleted the jayemar/create-new-files-in-inbox branch September 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obsidian-inbox-directory should be used when visiting links that don't yet exist
2 participants