-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add offline games ("Over the board") #924
Conversation
deb9522
to
17e3d2f
Compare
Demonstration video: over_the_board.webm |
Everything looks really good so far! I think there should be an option to pick the piece color for the main player, so that you don't have to rotate the phone and give all the menus / options to the secondary player. There's an option in the original otb mode that I find particularly useful, where it flips all pieces and info for the person whose turn it is to move. Would that be something to consider? Having the option to add +15 seconds of time to your opponent's clock would be nice to have too. |
a791a1b
to
3c70d62
Compare
Thanks!
Sounds useful, I'll add it to the settings as well
Yeah, looks like it needs to be implemented in
Also a useful feature, but I'm not sure where we would put this button - Probably in the bottom bar? any other ideas? |
We'll reuse this for implementing the Over-the-Board clock
3c70d62
to
6194f01
Compare
Rebased against main and adapted to chessground API changes. Some updates on the comments above:
Added the usual "flip board" button in the bottom bar for this.
Done 👍
Since this is now planned for normal/online games as well (#936), let's wait for that to be done and then add it here as well |
6194f01
to
60ecf70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work! Thank you.
Closes #287
Design is pretty close to the old lichess app and the basic functionality is implemented. Some minor features from the old app are missing and could be added in follow-up PRs: