-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unrated puzzles option #1445
Conversation
264a498
to
c0203dd
Compare
Thanks for this! How does it work with batches? Puzzles work offline too. If you solve puzzle offline, the solution is saved until network is up again. Then batches of puzzle are solved at once. |
c0203dd
to
2bf2cbd
Compare
@veloce Good catch! I updated the testing section above with a video that shows me turning on/off my wifi and turning on/off the rating. I then checked that once the internet was back, the batch puzzle submissions were all correctly rated or not rated. I think this should be ready for a final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
This feature should be tested. Puzzles are already well tested so it should be relatively easy to add a widget test.
There is already a widget test that solves a puzzle. I guess we should reuse that and intercept the mock storage to verify that the rated flag is correctly saved in database depending on the preferences.
9f75ded
to
257d474
Compare
I've rebased your branch to fix the CI @CloudyDino |
I approved the code, but the puzzles tests are not OK. Can you have a look? Thanks. |
257d474
to
6022ddd
Compare
@veloce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job, thanks!
Unrated Puzzles
Close #1120
Close #297
Changes
add.rated.game.switch.mp4
logged.out.user.mp4
Testing
Tested using a proxy to spy on what app sends to API.
offline.testing.mp4
win: false, rated: true
win: true, rated: true
win: true, rated: false