Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcast game screen blinking when a new move is received #1313

Merged
merged 8 commits into from
Jan 12, 2025
Merged

Fix broadcast game screen blinking when a new move is received #1313

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4efc7d0
Fix broadcast game screen bliking when a new move is received.
julien4215 Dec 27, 2024
ae38426
Listen to broadcast providers to a lower level in the widget tree and
julien4215 Dec 28, 2024
08c43fd
Skip reload and error for the broadcast game controller
julien4215 Dec 28, 2024
e4dc563
Add shimmer loading for player widgets
julien4215 Dec 30, 2024
af206d1
Skip error in broadcast provider only if the provider has no data
julien4215 Dec 30, 2024
21f0699
Revert disabling tab indicator when loading
julien4215 Jan 10, 2025
4a6b85e
Allow user to access settings screen while loading broadcast game screen
julien4215 Jan 10, 2025
e859546
Fix loading indicator
julien4215 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions lib/src/view/broadcast/broadcast_game_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,19 +112,19 @@ class _BroadcastGameScreenState extends ConsumerState<BroadcastGameScreen>
),
],
),
body: switch ((broadcastRoundGameState, broadcastGameState)) {
(AsyncData(), AsyncData()) => _Body(
widget.tournamentId,
widget.roundId,
widget.gameId,
widget.tournamentSlug,
widget.roundSlug,
tabController: _tabController,
),
(AsyncError(:final error), _) => Center(child: Text('Cannot load broadcast game: $error')),
(_, AsyncError(:final error)) => Center(child: Text('Cannot load broadcast game: $error')),
_ => const Center(child: CircularProgressIndicator.adaptive()),
},
body:
(broadcastRoundGameState.hasValue && broadcastGameState.hasValue)
? _Body(
widget.tournamentId,
widget.roundId,
widget.gameId,
widget.tournamentSlug,
widget.roundSlug,
tabController: _tabController,
)
: (broadcastGameState.hasError || broadcastRoundGameState.hasError)
? const Center(child: Text('Cannot load broadcast game'))
: const Center(child: CircularProgressIndicator.adaptive()),
);
}
}
Expand Down
Loading