-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add button to expand collapsed variations #1137
Conversation
Thanks Tom!❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks for this.
@ijm8710 FYI after some discussion in #1111 (comment) we decided to revert this PR for now, due to several reasons:
|
Hey Tom appreciate you sharing the heads up, my only hope is that it's temporarily paused while it's rethought rather than becomes abandoned fully. Based on scanning the comments in the pr you shared I think that's the case, but hopefully I'm reading that right. |
We had some more discussion via DM about this, but the bullet points above are pretty much a summary - I think we should at least see if there's more feedback about this in the future. |
expand.webm