Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add button to expand collapsed variations #1137

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

tom-anders
Copy link
Collaborator

expand.webm

@ijm8710
Copy link

ijm8710 commented Nov 5, 2024

Thanks Tom!❤️

Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for this.

@veloce veloce merged commit 9550b08 into lichess-org:main Nov 6, 2024
1 check passed
@tom-anders
Copy link
Collaborator Author

@ijm8710 FYI after some discussion in #1111 (comment) we decided to revert this PR for now, due to several reasons:

  • Having the [+] and [-] buttons not in the same place is confusing and a bit irritating when expanind/collapsing variations
  • We could have the [+] and [-] at the start of an expanded/collapsed sideline instead, but then the icon is right next to a move button and becomes hard to press
  • It's not clear whether collapsing variations is really used that often (by the average user) - Even lichess.org does not display a collapse-button, but requires a right-click instead (but it does have the expand-button

@ijm8710
Copy link

ijm8710 commented Nov 7, 2024

@ijm8710 FYI after some discussion in #1111 (comment) we decided to revert this PR for now, due to several reasons:

  • Having the [+] and [-] buttons not in the same place is confusing and a bit irritating when expanind/collapsing variations

  • We could have the [+] and [-] at the start of an expanded/collapsed sideline instead, but then the icon is right next to a move button and becomes hard to press

  • It's not clear whether collapsing variations is really used that often (by the average user) - Even lichess.org does not display a collapse-button, but requires a right-click instead (but it does have the expand-button

Hey Tom appreciate you sharing the heads up, my only hope is that it's temporarily paused while it's rethought rather than becomes abandoned fully. Based on scanning the comments in the pr you shared I think that's the case, but hopefully I'm reading that right.

@tom-anders
Copy link
Collaborator Author

@ijm8710 FYI after some discussion in #1111 (comment) we decided to revert this PR for now, due to several reasons:

  • Having the [+] and [-] buttons not in the same place is confusing and a bit irritating when expanind/collapsing variations
  • We could have the [+] and [-] at the start of an expanded/collapsed sideline instead, but then the icon is right next to a move button and becomes hard to press
  • It's not clear whether collapsing variations is really used that often (by the average user) - Even lichess.org does not display a collapse-button, but requires a right-click instead (but it does have the expand-button

Hey Tom appreciate you sharing the heads up, my only hope is that it's temporarily paused while it's rethought rather than becomes abandoned fully. Based on scanning the comments in the pr you shared I think that's the case, but hopefully I'm reading that right.

We had some more discussion via DM about this, but the bullet points above are pretty much a summary - I think we should at least see if there's more feedback about this in the future.

veloce added a commit that referenced this pull request Nov 9, 2024
This reverts commit 9550b08, reversing
changes made to 81ae8de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants