Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent icon style #559

Closed
LSeelig opened this issue Feb 17, 2024 · 3 comments · Fixed by #564
Closed

Use consistent icon style #559

LSeelig opened this issue Feb 17, 2024 · 3 comments · Fixed by #564
Milestone

Comments

@LSeelig
Copy link

LSeelig commented Feb 17, 2024

The four icons at the bottom on the screen have an inconsistent styling. They each use different line thicknesses and detail levels. Please consider using more consistent and modern icons, especially for puzzles and tools.
Screenshot_20240217_110216.png

@veloce
Copy link
Contributor

veloce commented Feb 19, 2024

You're totally right about the tools icon.

I don't really want to change the puzzles icons though, as it is the one used in lichess website.

@veloce veloce closed this as completed in 803bf4a Feb 19, 2024
@LSeelig
Copy link
Author

LSeelig commented Feb 19, 2024

You're totally right about the tools icon.

I don't really want to change the puzzles icons though, as it is the one used in lichess website.

It's not egregious, but I do think it's a tad skeuomorphic, and the style of the app already heavily departs from the website. Consistency is important. If you aren't going to switch it with, say, a puzzle piece, consider tweaking the line thickness while keeping the metaphor.

@veloce
Copy link
Contributor

veloce commented Feb 20, 2024

I changed my mind. The lichess icon is already present in other parts of the app, and in the bottom bar the consistency is most important. Thanks for insisting.

@veloce veloce reopened this Feb 20, 2024
@veloce veloce added this to the Alpha 2 milestone Feb 20, 2024
veloce added a commit that referenced this issue Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants