Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sparkline puzzle rating #7405

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Conversation

kraktus
Copy link
Member

@kraktus kraktus commented Oct 2, 2020

Puzzle rating graph was too flat due to this issue: fnando/sparkline#17

before:
Screen Shot 2020-10-02 at 13 34 17
after:
Screen Shot 2020-10-02 at 15 36 47 copy
Screen Shot 2020-10-02 at 15 36 47

@ornicar
Copy link
Collaborator

ornicar commented Oct 2, 2020

I was actually thinking of removing it... the coloured list under the board almost does the same and is just more useful because it's clickable

@kraktus
Copy link
Member Author

kraktus commented Oct 2, 2020

It doesn't add any information but it looks visually nice. I tried to add a tooltip (using onmousemove function provided by the library) with the rating of the player at that time, without success so far

@ornicar ornicar merged commit 84ecf4b into lichess-org:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants