Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better challenger: Improved template #16004

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

SergioGlorias
Copy link
Contributor

Correct what should be #15628
params should not only work in #hook
Added support for selecting variants

SergioGlorias and others added 4 commits September 4, 2024 18:56
Correct what should be lichess-org#15628
params should not only work in `#hook`
Added support for selecting variants
to avoid re-hardcoding all variants again.
The server will validate anyway.
Copy link
Collaborator

@ornicar ornicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It remains very obscure and niche, eventually we need an UI that generates these URLs

ui/lobby/src/ctrl.ts Show resolved Hide resolved
@SergioGlorias
Copy link
Contributor Author

It remains very obscure and niche, eventually we need an UI that generates these URLs

Yes, it's true, it's still half-hidden and not to mention that it hasn't been publicised that this option exists

@ornicar ornicar merged commit ecc1d98 into lichess-org:master Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants