Show 3-5 fold positions in analysis #15999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraktus
changed the title
|
If you're wanting the indicator to be a glyph on the moved piece, custom svgs can provide uniformity (like blunder/mistake/inaccuracies). But as a user, I probably prefer the move list annotations alone. "Why is there is a 3 on my queen, stop ruining lichess!" |
Only checking for the last epd, which is the only one that could lead to three/five-fold repetition. Previously code could be triggered on EPDs that were repeated 3 times, but where neither players claimed three-fold.
The function was unused until now
Only seems to be used to CSS, values found in `nodeClasses`, `lila/ui/analyse/src/treeView/common.ts`
```
inaccuracy: glyphIds.includes(6),
mistake: glyphIds.includes(2),
blunder: glyphIds.includes(4),
good: glyphIds.includes(1),
brilliant: glyphIds.includes(3),
interesting: glyphIds.includes(5),
```
kraktus
changed the title
|
Following feedback here: https://hq.lichess.ovh/#narrow/stream/1-general/topic/positions.20of.203-5.20fold.20repetitions/near/3445933 went for unicode number for now. The styling can always be polished later like for puzzle feedback, for the SVG icon I was thinking about the number inside ♻️ or |
kraktus
commented
Sep 5, 2024
ui/analyse/src/ctrl.ts
Outdated
Comment on lines
217
to
220
| const mainline = treeOps.mainlineNodeList(this.tree.root); | ||
| if (this.data.game.status.name == 'draw') { | ||
| add3or5FoldGlyphs(mainline); | ||
| } |
There was a problem hiding this comment.
Not sure if it's the correct place to put
|
Currently not showing on the game page, only analysis, not sure if it's good to add it there too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A way for people to quickly see which positions implied the 3-5 fold repetition (for #13459 and the many forum posts about it)
This is a WIP for now, looking for feedback on two things:
First attempt using unicode fractions, unfortunately
³⁄₃does not render well on Safari/FirefoxAnother attempt
TODO: should not be shown in studies, only in games list
Another idea, list the positions at the end of the movelist (mockup, would be clickable)
