Fix: Update to UI for disabling and enabling the chat room (#15943) #15961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Itachii27
commented
Aug 26, 2024
•
Itachii27
commented
- These changes resolves the issue Update to UI for disabling and enabling the chat room to make it more clear #15943
- Screenshots for references:
kraktus
reviewed
Aug 26, 2024
ui/chat/css/build/chat.mod.scss
Outdated
| @@ -1,2 +1,3 @@ | |||
| @import '../../../common/css/plugin'; | |||
| @import '../chat.mod'; | |||
| @import '../../../common/css/form/cmn-toggle'; | |||
There was a problem hiding this comment.
Hello, this import is probably not at the right place, most likely should be in _chat, you should test viewing as a spectator
|
@kraktus I have done the changes and tested the same. Please review the PR. |
|
Hello, no time to review this week |
|
came into conflict due to new updates to assets |
|
Fixed the conflict and tested it. Looks good! |
the chat id is the game id
since the checkbox is not visible, the title would never appear
|
resolved #15943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.