Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure flagged users do not appear on TV #15481

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

r22222
Copy link

@r22222 r22222 commented Jun 12, 2024

This pull request addresses issue #14858, which highlights the problem of flagged accounts appearing on TV. The solution implemented ensures that users who are flagged will not be featured on TV.

Changes Made:

•	Modified tv/src/main/Env.scala:
•	Modified tv/src/main/TvSyncActor.scala:

Credit to tors42 for providing the initial solution and code snippets.

@ornicar
Copy link
Collaborator

ornicar commented Jun 12, 2024

The PR does not compile. Please test the changes before setting the PR as being ready for review.

@ornicar ornicar marked this pull request as draft June 12, 2024 06:45
}
.foreach(_.addCandidate(g))
userApi
.countEngines(g.userIds)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds a hit to the database every time a game starts, so about 5 million requests a day.

Copy link
Contributor

@bastianpedersen bastianpedersen Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you propose an alternative solution? I am asking out of curiosity as I am trying to get a better understanding of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants