Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgn idempotency #10781

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

johnboltum
Copy link

@johnboltum johnboltum commented Apr 6, 2022

So far changes only made in /modules/study/src/main/PgnDump.scala

New Functions are combineComments and gamebookComment.

combineComments was created to reduce duplicate code in the ofChapter(...) and node2moves(...) functions in PgnDump.scala. A more descriptive name might be possible.

gamebookComment was templated after shapeComment, and was created to format gamebookComments (i.e. interactive study comments) for PGN exporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant