Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use corepack for pnpm #87

Merged
merged 3 commits into from
May 14, 2024
Merged

use corepack for pnpm #87

merged 3 commits into from
May 14, 2024

Conversation

fitztrev
Copy link
Member

@fitztrev fitztrev commented May 8, 2024

No description provided.

@trevorbayless
Copy link
Member

I came across this when trying to ./lila-docker format today after receiving the following:

Screenshot_20240514_113808

I tested out the changes in this PR and they work, but unfortunately are adding additional prompts on start and format (as I'm sure you saw):

Screenshot_20240514_114155

An alternative (but certainly not ideal) approach could be to remove RUN corepack enable and add ENV COREPACK_ENABLE_STRICT=0 before RUN npm install --global pnpm@9 in the two dockerfiles. This works as well, and continues without user prompt but does supply a warning:

Screenshot_20240514_115628

As mentioned, certainly not ideal but figured I'd some discussion to the PR for thought.

@fitztrev
Copy link
Member Author

I actually hadn't seen that prompt yet. I think I was still using a cached image that had pnpm 9.1.0 so it didn't need to download a different version yet.

I looked into the docs and found the COREPACK_ENABLE_DOWNLOAD_PROMPT env and it seems to work. Could you try it out and see if that's an option?

@trevorbayless
Copy link
Member

Nice find on that environment variable. Tested and working!

@fitztrev fitztrev merged commit f714605 into main May 14, 2024
5 checks passed
@fitztrev fitztrev deleted the corepack branch May 14, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants