New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tournament bug fixes and improvements #1900

Merged

veloce merged 3 commits into lichess-org:master from jas14:1897-tournament-password-join-fix

Nov 18, 2021

Collaborator

jas14 commented Oct 25, 2021 •

edited

Loading

Discovered while investigating #1897.

Tournament with no chat enabled was crashing locally due to an unkeyed null node; replaced with empty keyed fragment
Tournaments do not require re-entering passwords to resume play from pause, updated locally to not re-require password
Tournament join API response contains an error message, display that to the user when available

jas14 added 3 commits

October 25, 2021 09:33


          Fix tournament detail page when chat is disabled

9c29f82


          Display error messages returned by tournament join API

a703801


          Skip password prompt if previously joined tournament

30594e9

veloce merged commit ae747d1 into lichess-org:master

jas14 deleted the 1897-tournament-password-join-fix branch

November 18, 2021 11:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet