Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in VNNIT setup #31

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fixed bug in VNNIT setup #31

merged 2 commits into from
Feb 2, 2024

Conversation

alheinecke
Copy link
Collaborator

No description provided.

@alheinecke
Copy link
Collaborator Author

@rengolin it seems you changed the buildkite config, but the scripts haven't been submitted to repository. Can you please do.

@rengolin
Copy link
Contributor

rengolin commented Feb 1, 2024

@rengolin it seems you changed the buildkite config, but the scripts haven't been submitted to repository. Can you please do.

All of the config was added in the main repo, not here. Is there any of those that should be here?

@alheinecke
Copy link
Collaborator Author

All of the config was added in the main repo, not here. Is there any of those that should be here?

Wouldn't it make sense to add the libxsmm-dnn configs to libxsmm-dnn. Also I feel it must be added there, the currently link goes to scripts... and it feel it cannot be in a submodule.

@rengolin
Copy link
Contributor

rengolin commented Feb 1, 2024

Wouldn't it make sense to add the libxsmm-dnn configs to libxsmm-dnn. Also I feel it must be added there, the currently link goes to scripts... and it feel it cannot be in a submodule.

Hm, it seems these two don't run in libxsmm, so it should be simpler than thought

Copy link
Contributor

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fixed, please rebase

@alheinecke alheinecke merged commit af807bc into main Feb 2, 2024
2 checks passed
@alheinecke alheinecke deleted the fix_vnniT branch February 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants