win: rename platform to msbplatform in vcbuild #868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe call it |
This variable is used to select 32 or 64 bit builds when invoking MSBuild. The Visual C++ Build Tools also use the `platform` variable name, resulting in a conflict when vcvarsall.bat is called. Thus, it is necessary to rename it. Ref: libuv#839
joaocgreis
force-pushed
the
joaocgreis-G5C-rename-platform
branch
from
c0386ed to
f9e5a9f
Compare
|
Updated to |
|
LGTM |
saghul
pushed a commit
that referenced
this pull request
May 12, 2016
This variable is used to select 32 or 64 bit builds when invoking MSBuild. The Visual C++ Build Tools also use the `platform` variable name, resulting in a conflict when vcvarsall.bat is called. Thus, it is necessary to rename it. Ref: #839 PR-URL: #868 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 11e93aa, thanks Joao! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is used to select 32 or 64 bit builds when invoking MSBuild.
The Visual C++ Build Tools also use the
platformvariable name, resulting in a conflict whenvcvarsall.batis called. Thus, it is necessary to rename it. This is similar to what was done in node in nodejs/node#5627 .This enables building with Visual C++ Build Tools without any change.
Ref: #839