libusb backend: stabilize device path, superseeds: #117 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youw
approved these changes
Jun 25, 2021
|
Looks good to me. |
derekatkins
approved these changes
Jun 25, 2021
Youw
reviewed
Jun 25, 2021
format the path like the linux kernel does: <busnum>-<port[.port]>…:<config num>.<interface num> See also libusb#117 Closes: libusb#117
bearsh
force-pushed
the
libusb_stable_path
branch
from
998fe4c to
d03f799
Compare
|
Yeah. It is more about agreement/code-style/source consistency. |
|
I've tested this out with several of my devices. With and without hubs (multiple hubs) - so far looking good! |
|
Tested successfully with my keyboard driver.
|
netfab
added a commit
to netfab/GLogiK
that referenced
this pull request
Jul 4, 2021
We will need it after hidapi device path stabilization. libusb/hidapi#291 USBInit class now have its own source files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format the path like the linux kernel does:
-<port[.port]>…:.
See also #117
Closes: #117