Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change bids and lists to use 1 dummy instead of 2 #149

Merged
merged 5 commits into from
Apr 9, 2023

Conversation

jadwahab
Copy link
Member

@jadwahab jadwahab commented Apr 9, 2023

Move out 2 dummy code into separate file. Not sure whether to keep or just remove. Kept for now.

@mergify mergify bot added the feature label Apr 9, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 60.47% and project coverage change: -0.19 ⚠️

Comparison is base (da68c79) 80.80% compared to head (c85e49c) 80.61%.

❗ Current head c85e49c differs from pull request most recent head 07f43a3. Consider uploading reports for the commit 07f43a3 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   80.80%   80.61%   -0.19%     
==========================================
  Files          37       38       +1     
  Lines        3985     4112     +127     
==========================================
+ Hits         3220     3315      +95     
  Misses        546      546              
- Partials      219      251      +32     
Impacted Files Coverage Δ
ord/2dummies.go 51.77% <56.52%> (ø)
ord/bid.go 59.57% <59.57%> (ø)
ord/list.go 54.43% <68.42%> (ø)
bscript/script.go 66.78% <75.00%> (+7.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jadwahab jadwahab merged commit 79b6991 into master Apr 9, 2023
@jadwahab jadwahab deleted the feat/bid-list-1-dummy branch April 9, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants