Skip to content

Commit

Permalink
fix: british spelling (american linter) lol
Browse files Browse the repository at this point in the history
  • Loading branch information
Jad Wahab committed Feb 27, 2021
1 parent afaea12 commit 43b22c0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions internalsigner.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ func (is *InternalSigner) Sign(index uint32, unsignedTx *Tx) (signedTx *Tx, err
is.SigHashFlag = sighash.AllForkID
}

// TODO: v2 put tx serialisation in parent/general func (tx.Sign) so that the
// TODO: v2 put tx serialization in parent/general func (tx.Sign) so that the
// functions like that implement the Signer interface only sign and don't do
// tx input serialisation as well. So this Sign func would probably need to take
// tx input serialization as well. So this Sign func would probably need to take
// Sign(sigdigest []bytes)
var sh []byte
if sh, err = unsignedTx.GetInputSignatureHash(index, is.SigHashFlag); err != nil {
Expand Down
4 changes: 2 additions & 2 deletions tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,8 @@ func (tx *Tx) toBytesHelper(index int, lockingScript []byte) []byte {
// signing implementations can be used to sign the transaction -
// for example internal/local or external signing.
func (tx *Tx) Sign(index uint32, s Signer) error {
// TODO: v2 put tx serialisation here so that the Signer.Sign
// func only does signing and not also serialisation which
// TODO: v2 put tx serialization here so that the Signer.Sign
// func only does signing and not also serialization which
// should be done here.

signedTx, err := s.Sign(index, tx)
Expand Down

0 comments on commit 43b22c0

Please sign in to comment.