Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cmake work based on jcelerier's pull request. #8

Closed
wants to merge 4 commits into from

Conversation

mdsitton
Copy link

I tend to build cmake projects in a seperate build directory so files dont pollute the source tree, and it simplifies ignoring the cmake build files. This is mostly unrelated to the cmake changes, just explaining the .gitignore change.

WIN32 and _USRDLL i grabbed out of Makefile.msvc i'm not sure if they are actually required though.

This satisfies my needs, but if you want I can also look into getting the tests and examples building.

@mdsitton
Copy link
Author

I might also look into getting cmake to generate the config.h so other platforms work properly with cmake.

@mdsitton
Copy link
Author

mdsitton commented Oct 30, 2016

Digging through the 2 workarounds in config,h

#pragma warning(disable: 4305)
#define inline __inline

They don't seem to be needed anymore with Visual Studio 2015.
No idea when they would have been fixed though

@mdsitton
Copy link
Author

mdsitton commented Oct 30, 2016

I based the cmake generated config file on the windows config, but didn't include anything that wasn't actually used by libsamplerate.

On windows for the FindSndfile an env variable should be set that points to the correct installations, though i'll need to set it up so it can handle both x86 and x86_64 versions. All of this can be done within cmake though.

@erikd
Copy link
Member

erikd commented Oct 30, 2016

@mdsitton Thanks for working on this. I would like to see a proper CMake based build system for libsamplerate, but I prefer not to merge it until its at least near being on par with the autotool based build system. That includes build examples and tests and running the tests.

@mdsitton
Copy link
Author

Alright, good to know, I'll start working on that next.

@Bobo1239
Copy link
Contributor

Bobo1239 commented Apr 5, 2018

This PR can be closed as #24 supersedes it.

@erikd erikd closed this Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants