Skip to content

Commit

Permalink
xcode+cmake: Use SDL3_image.framework/SDL3_image as IMPORTED_LOCATION
Browse files Browse the repository at this point in the history
Not adding /SDL3_image causes CMake to no longer set the RUNPATh on
binaries in the build directory.
It also breaks compatibility with CMake versions older then 3.28.
  • Loading branch information
madebr committed Jan 25, 2025
1 parent c4f1bf1 commit 4c9986e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Xcode/pkg-support/resources/CMake/SDL3_imageConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ if(NOT TARGET SDL3_image::SDL3_image-shared)
set_target_properties(SDL3_image::SDL3_image-shared
PROPERTIES
FRAMEWORK "TRUE"
IMPORTED_LOCATION "${_sdl3_image_framework_path}"
IMPORTED_LOCATION "${_sdl3_image_framework_path}/SDL3_image"
COMPATIBLE_INTERFACE_BOOL "SDL3_SHARED"
INTERFACE_SDL3_SHARED "ON"
COMPATIBLE_INTERFACE_STRING "SDL_VERSION"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ if(NOT TARGET SDL3_image::SDL3_image-shared)
set_target_properties(SDL3_image::SDL3_image-shared
PROPERTIES
FRAMEWORK "TRUE"
IMPORTED_LOCATION "${_sdl3_image_framework_path}"
IMPORTED_LOCATION "${_sdl3_image_framework_path}/SDL3_image"
)
endif()
set_target_properties(SDL3_image::SDL3_image-shared
Expand Down

0 comments on commit 4c9986e

Please sign in to comment.