Skip to content

Add workaround to fix #14067 #14123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −0
Open

Add workaround to fix #14067 #14123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b23bd94
Fix for #14067
eafton Oct 2, 2025
37177df
Fix for #14067
eafton Oct 2, 2025
e477016
Fix for SDL_windowsjoystick.c
eafton Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/joystick/windows/SDL_windowsjoystick.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,9 @@ static bool WINDOWS_JoystickOpen(SDL_Joystick *joystick, int device_index)

static bool WINDOWS_JoystickRumble(SDL_Joystick *joystick, Uint16 low_frequency_rumble, Uint16 high_frequency_rumble)
{
if (!joystick->hwdata) {
return SDL_SetError("Rumble failed, device disconnected.");
}
#ifdef SDL_JOYSTICK_XINPUT
if (joystick->hwdata->bXInputDevice) {
return SDL_XINPUT_JoystickRumble(joystick, low_frequency_rumble, high_frequency_rumble);
Expand Down Expand Up @@ -629,6 +632,10 @@ static void WINDOWS_JoystickUpdate(SDL_Joystick *joystick)
// Function to close a joystick after use
static void WINDOWS_JoystickClose(SDL_Joystick *joystick)
{
if (!joystick->hwdata) {
SDL_SetError("Unable to close joystick, hwdata is NULL.");
return;
}
#ifdef SDL_JOYSTICK_XINPUT
if (joystick->hwdata->bXInputDevice) {
SDL_XINPUT_JoystickClose(joystick);
Expand Down
Loading