Fix content scanner creating false positive playlist entries #8333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the following circumstance the content scanner will add a false positive to a playlist:
This results in a playlist containg entries for the first and second items, even though the first item should not have been included.
The issue occurs because:
archive_crc
is not reset between the scanning of the second and the third item.crc
is looked up in the rdb, the second item'sarchive_crc
is matched, which causes the false positive:In addition, in the playlist, the false positive item wrongly gets the label and crc32 of the second item.