Makefile.common: Fix segfaults with --disable-builtinflac. #6637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the crash when RetrorArch is built with
--disable-builtinflac
and scanning chd v5 files.A relatively recent commit exposed the problem when I previously forget to define
-DHAVE_FLAC
inMakefile.common
...It will still fail scanning with
--disable-flac
, but earlier behavior would have not built chd support without flac at all so I would consider this a different bug.Related Issues
#6553
Related Pull Requests
997c24a
Reviewers
@twinaphex @i30817