Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.common: Fix segfaults with --disable-builtinflac. #6637

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Makefile.common: Fix segfaults with --disable-builtinflac. #6637

merged 1 commit into from
Apr 27, 2018

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Apr 27, 2018

Description

This fixes the crash when RetrorArch is built with --disable-builtinflac and scanning chd v5 files.

A relatively recent commit exposed the problem when I previously forget to define -DHAVE_FLAC in Makefile.common...

It will still fail scanning with --disable-flac, but earlier behavior would have not built chd support without flac at all so I would consider this a different bug.

Related Issues

#6553

Related Pull Requests

997c24a

Reviewers

@twinaphex @i30817

@inactive123 inactive123 merged commit e52bb69 into libretro:master Apr 27, 2018
@orbea orbea deleted the flac branch April 27, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants