[beken-72xx] Fix deep_sleep time parameter overflow #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba2k2
changed the title
kuba2k2
requested changes
Jan 3, 2024
| @@ -21,12 +21,12 @@ void lt_deep_sleep_unset_gpio(uint32_t gpio_index_map) { | |||
|
|
|||
| void lt_deep_sleep_config_timer(uint32_t sleep_duration) { | |||
| deep_sleep_param.wake_up_way |= PS_DEEP_WAKEUP_RTC; | |||
| uint64_t duration_math = 32768 * sleep_duration; | |||
| if (duration_math / 1000 > 0xFFFFFFFF) { | |||
| uint32_t duration_math = (32768 * ((float) sleep_duration)/1000.0); | |||
There was a problem hiding this comment.
To avoid unnecessary casting, could you try 32.768 * sleep_duration? This way the division is avoided, and casting is implicit because the first operand is a float.
| uint64_t duration_math = 32768 * sleep_duration; | ||
| if (duration_math / 1000 > 0xFFFFFFFF) { | ||
| uint32_t duration_math = (32768 * ((float) sleep_duration)/1000.0); | ||
| if (duration_math > 0xFFFFFFFF) { |
There was a problem hiding this comment.
This can never be larger than 0xFFFFFFFF now. Is that even needed?
cap9qd
added a commit
to cap9qd/libretiny
that referenced
this pull request
Feb 1, 2024
cap9qd
added a commit
to cap9qd/libretiny
that referenced
this pull request
Feb 21, 2024
This reverts commit 0518e21.
cap9qd
added a commit
to cap9qd/libretiny
that referenced
this pull request
Feb 21, 2024
This reverts commit 0518e21.
cap9qd
added a commit
to cap9qd/libretiny
that referenced
this pull request
Feb 21, 2024
cap9qd
added a commit
to cap9qd/libretiny
that referenced
this pull request
Feb 21, 2024
cap9qd
added a commit
to cap9qd/libretiny
that referenced
this pull request
Feb 21, 2024
|
This can probably be closed as duplicate of the now-completed #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #230